[Findit] Strip platform from step_name before triggering try job.

appengine/findit/waterfall/try_job_util.py

 # Copyright 2015 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import logging
 
 from google.appengine.api import modules
 from google.appengine.ext import ndb
 
 from model import wf_analysis_status
@@ skipping 61 matching lines @@
         else:
           targeted_tests.append(failure_name)
 
     need_new_try_job = need_new_try_job or failure_need_try_job
     last_pass = (failure_last_pass if failure_last_pass and
                  failure_last_pass < last_pass else last_pass)
 
   return targeted_tests, need_new_try_job, last_pass
 
 
+def _StripPlatform(targeted_tests):

[lijeffrey, 2016/03/10 00:43:56]

nit: just for clarity maybe rename this '_GetTargetedTestsWithoutPlatform' or
something similar and add a doc string

[chanli, 2016/03/10 23:31:51]

Function deleted.

+  if not targeted_tests:
+    return None
+
+  updated_tests = {}
+  for step_name, tests in targeted_tests.iteritems():
+    updated_tests[step_name.strip()[0]] = tests

[stgao, 2016/03/10 00:39:30]

How about using the value of tag "name" in the Swarming tasks instead?

IIRC, we already pull information from Swarming Server for the whole build to
determine which steps are run on Swarming.
For those not running on Swarming, just default to the step name from build json
data.

https://apis-explorer.appspot.com/apis-explorer/?base=https://chromium-swarm....

[lijeffrey, 2016/03/10 00:43:56]

are you sure you want step_name.strip()[0]? I think that only gives you the
first letter?

[chanli, 2016/03/10 23:31:51]

Right... I wanted to use split... Done

[chanli, 2016/03/10 23:31:51]

You're right, and actually this patch won't work because it just modified
original target_tests but not the updated_one.

+
+  return updated_tests
+
+
 @ndb.transactional
 def _NeedANewTryJob(
     master_name, builder_name, build_number, failed_steps, failure_result_map):
   """Checks if a new try_job is needed."""
   need_new_try_job = False
   last_pass = build_number
 
   if 'compile' in failed_steps:
     try_job_type = TryJobType.COMPILE
     targeted_tests = None
@@ skipping 15 matching lines @@
       if try_job.failed:
         try_job.status = wf_analysis_status.PENDING
         try_job.put()
       else:
         need_new_try_job = False
     else:
       try_job = WfTryJob.Create(
           master_name, builder_name, build_number)
       try_job.put()
 
+  targeted_tests = _StripPlatform(targeted_tests)
+
   return need_new_try_job, last_pass, try_job_type, targeted_tests
 
 
 def _GetFailedTargetsFromSignals(signals):
   compile_targets = []
 
   if not signals or 'compile' not in signals:
     return compile_targets
 
   for source_target in signals['compile']['failed_targets']:
@@ skipping 54 matching lines @@
               pipeline.pipeline_status_path, try_job_type)
     else:  # pragma: no cover
       logging_str = (
           'Try job was scheduled for build %s, %s, %s: %s because of %s '
           'failure.') % (
               master_name, builder_name, build_number,
               pipeline.pipeline_status_path, try_job_type)
     logging.info(logging_str)
 
   return failure_result_map