Enumerate URIs of all types in type errors in order to help the user diagnose

Enumerate URIs of all types in type errors in order to help the user diagnose
the error (it was previously only printed for types with identical names).
Cleanup and simplify construction of type errors.

R=hausner@google.com, srdjan@google.com

Committed: https://github.com/dart-lang/sdk/commit/ba69c8a8983e0ed6bf3acc0866707da4e7725ea6

[regis, 2016-03-09 22:14:49]

regis@google.com changed reviewers:
+ hausner@google.com, srdjan@google.com

[hausner, 2016-03-09 22:32:43]

lgtm

https://codereview.chromium.org/1778133002/diff/1/runtime/vm/object.cc
File runtime/vm/object.cc (right):

https://codereview.chromium.org/1778133002/diff/1/runtime/vm/object.cc#newcod...
runtime/vm/object.cc:6164: String::Handle(FunctionType::Handle(
Indentation wrong, I think.

[srdjan, 2016-03-09 22:38:23]

lgtm

https://codereview.chromium.org/1778133002/diff/1/runtime/lib/object.cc
File runtime/lib/object.cc (right):

https://codereview.chromium.org/1778133002/diff/1/runtime/lib/object.cc#newco...
runtime/lib/object.cc:158: location, AbstractType::Handle(),
AbstractType::Handle(),
AbstractType::Handle(zone) x 2

https://codereview.chromium.org/1778133002/diff/1/runtime/lib/object.cc#newco...
runtime/lib/object.cc:273:
String::Handle(String::New(bound_error.ToErrorCString()));
zone,

https://codereview.chromium.org/1778133002/diff/1/runtime/lib/object.cc#newco...
runtime/lib/object.cc:275: location, instance_type, AbstractType::Handle(),
zone

https://codereview.chromium.org/1778133002/diff/1/runtime/vm/code_generator.cc
File runtime/vm/code_generator.cc (right):

https://codereview.chromium.org/1778133002/diff/1/runtime/vm/code_generator.c...
runtime/vm/code_generator.cc:207: location, AbstractType::Handle(),
AbstractType::Handle(),
Add zone parameters

https://codereview.chromium.org/1778133002/diff/1/runtime/vm/code_generator.c...
runtime/vm/code_generator.cc:246: location, AbstractType::Handle(),
AbstractType::Handle(),
ditto

https://codereview.chromium.org/1778133002/diff/1/runtime/vm/code_generator.c...
runtime/vm/code_generator.cc:589: location, src_type, dst_type, dst_name,
String::Handle());
ditto

https://codereview.chromium.org/1778133002/diff/1/runtime/vm/exceptions.cc
File runtime/vm/exceptions.cc (right):

https://codereview.chromium.org/1778133002/diff/1/runtime/vm/exceptions.cc#ne...
runtime/vm/exceptions.cc:513: OS::Print("%s\n", error_msg.ToCString());
Replace OS::Print with THR_Print

[regis, 2016-03-09 23:15:41]

Thank you both.

https://codereview.chromium.org/1778133002/diff/1/runtime/lib/object.cc
File runtime/lib/object.cc (right):

https://codereview.chromium.org/1778133002/diff/1/runtime/lib/object.cc#newco...
runtime/lib/object.cc:158: location, AbstractType::Handle(),
AbstractType::Handle(),
On 2016/03/09 22:38:22, srdjan wrote:
> AbstractType::Handle(zone) x 2

Done here and above.

https://codereview.chromium.org/1778133002/diff/1/runtime/lib/object.cc#newco...
runtime/lib/object.cc:273:
String::Handle(String::New(bound_error.ToErrorCString()));
On 2016/03/09 22:38:22, srdjan wrote:
> zone, 

Done.

https://codereview.chromium.org/1778133002/diff/1/runtime/lib/object.cc#newco...
runtime/lib/object.cc:275: location, instance_type, AbstractType::Handle(),
On 2016/03/09 22:38:22, srdjan wrote:
> zone

Done.

https://codereview.chromium.org/1778133002/diff/1/runtime/vm/code_generator.cc
File runtime/vm/code_generator.cc (right):

https://codereview.chromium.org/1778133002/diff/1/runtime/vm/code_generator.c...
runtime/vm/code_generator.cc:207: location, AbstractType::Handle(),
AbstractType::Handle(),
On 2016/03/09 22:38:22, srdjan wrote:
> Add zone parameters

Done.

https://codereview.chromium.org/1778133002/diff/1/runtime/vm/code_generator.c...
runtime/vm/code_generator.cc:246: location, AbstractType::Handle(),
AbstractType::Handle(),
On 2016/03/09 22:38:23, srdjan wrote:
> ditto

Done.

https://codereview.chromium.org/1778133002/diff/1/runtime/vm/code_generator.c...
runtime/vm/code_generator.cc:589: location, src_type, dst_type, dst_name,
String::Handle());
On 2016/03/09 22:38:23, srdjan wrote:
> ditto

Done.

https://codereview.chromium.org/1778133002/diff/1/runtime/vm/exceptions.cc
File runtime/vm/exceptions.cc (right):

https://codereview.chromium.org/1778133002/diff/1/runtime/vm/exceptions.cc#ne...
runtime/vm/exceptions.cc:513: OS::Print("%s\n", error_msg.ToCString());
On 2016/03/09 22:38:23, srdjan wrote:
> Replace OS::Print with THR_Print

Done.

https://codereview.chromium.org/1778133002/diff/1/runtime/vm/object.cc
File runtime/vm/object.cc (right):

https://codereview.chromium.org/1778133002/diff/1/runtime/vm/object.cc#newcod...
runtime/vm/object.cc:6164: String::Handle(FunctionType::Handle(
On 2016/03/09 22:32:43, hausner wrote:
> Indentation wrong, I think.

Done.

[regis, 2016-03-09 23:16:51]

Description was changed from

==========
Enumerate URIs of all types in type errors in order to help the user diagnose
the error (it was previously only printed for types with identical names).
Cleanup and simplify construction of type errors.
==========

to

==========
Enumerate URIs of all types in type errors in order to help the user diagnose
the error (it was previously only printed for types with identical names).
Cleanup and simplify construction of type errors.

R=hausner@google.com, srdjan@google.com

Committed:
https://github.com/dart-lang/sdk/commit/ba69c8a8983e0ed6bf3acc0866707da4e7725ea6
==========

[regis, 2016-03-09 23:16:52]

Committed patchset #2 (id:20001) manually as
ba69c8a8983e0ed6bf3acc0866707da4e7725ea6 (presubmit successful).