Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Unified Diff: runtime/vm/symbols.h

Issue 1778133002: Enumerate URIs of all types in type errors in order to help the user diagnose (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: address comments Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/parser.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/symbols.h
diff --git a/runtime/vm/symbols.h b/runtime/vm/symbols.h
index 9390ee1c08940213ce28f3d3fe059cd513213690..ba20f529ce8a8f03c86ec4136aab437a563f7b03 100644
--- a/runtime/vm/symbols.h
+++ b/runtime/vm/symbols.h
@@ -309,8 +309,6 @@ class ObjectPointerVisitor;
V(NullThrownError, "NullThrownError") \
V(IsolateSpawnException, "IsolateSpawnException") \
V(BooleanExpression, "boolean expression") \
- V(Malformed, "malformed") \
- V(Malbounded, "malbounded") \
V(MegamorphicMiss, "megamorphic_miss") \
V(CommaSpace, ", ") \
V(ColonSpace, ": ") \
@@ -318,6 +316,9 @@ class ObjectPointerVisitor;
V(SpaceExtendsSpace, " extends ") \
V(SpaceWhereNewLine, " where\n") \
V(SpaceIsFromSpace, " is from ") \
+ V(InTypeCast, " in type cast") \
+ V(TypeQuote, "type '") \
+ V(QuoteIsNotASubtypeOf, "' is not a subtype of ") \
V(SpaceOfSpace, " of ") \
V(SwitchExpr, ":switch_expr") \
V(TwoNewlines, "\n\n") \
@@ -499,9 +500,12 @@ class Symbols : public AllStatic {
static const String& NewLine() {
return *(symbol_handles_[kNullCharId + '\n']);
}
- static const String& DoubleQuotes() {
+ static const String& DoubleQuote() {
return *(symbol_handles_[kNullCharId + '"']);
}
+ static const String& SingleQuote() {
+ return *(symbol_handles_[kNullCharId + '\'']);
+ }
static const String& LowercaseR() {
return *(symbol_handles_[kNullCharId + 'r']);
}
« no previous file with comments | « runtime/vm/parser.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698