Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(483)

Issue 1778103003: Invoke CallToRuntime via Thread instead of ObjectPools. (Closed)

Created:
4 years, 9 months ago by rmacnak
Modified:
4 years, 9 months ago
Reviewers:
Florian Schneider
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Invoke CallToRuntime via Thread instead of ObjectPools. Most functions use CallToRuntime for the stack overflow check. precompiled dart2js arm 20388895 -> 20308640 (-0.39%) R=fschneider@google.com Committed: https://github.com/dart-lang/sdk/commit/e386db978e5b2a885550f971c375a078e7abcad3

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -5 lines) Patch
M runtime/vm/assembler_arm.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/assembler_arm.cc View 1 1 chunk +7 lines, -0 lines 0 comments Download
M runtime/vm/assembler_arm64.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/assembler_arm64.cc View 1 1 chunk +7 lines, -0 lines 0 comments Download
M runtime/vm/assembler_ia32.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/assembler_ia32.cc View 1 1 chunk +6 lines, -0 lines 0 comments Download
M runtime/vm/assembler_mips.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/assembler_mips.cc View 1 1 chunk +7 lines, -0 lines 0 comments Download
M runtime/vm/assembler_x64.h View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/assembler_x64.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M runtime/vm/runtime_entry_arm.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/runtime_entry_arm64.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/runtime_entry_ia32.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/runtime_entry_mips.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/runtime_entry_x64.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/thread.h View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
rmacnak
4 years, 9 months ago (2016-03-10 18:14:45 UTC) #3
Florian Schneider
Lgtm.
4 years, 9 months ago (2016-03-11 07:59:30 UTC) #4
rmacnak
4 years, 9 months ago (2016-03-11 18:03:18 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
e386db978e5b2a885550f971c375a078e7abcad3 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698