runtime/vm/runtime_entry_x64.cc - Issue 1778103003: Invoke CallToRuntime via Thread instead of ObjectPools.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: runtime/vm/runtime_entry_x64.cc

Issue 1778103003: Invoke CallToRuntime via Thread instead of ObjectPools. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « runtime/vm/runtime_entry_mips.cc ('k') | runtime/vm/thread.h » ('j') | no next file with comments »

OLD	NEW
1 // Copyright (c) 2011, the Dart project authors. Please see the AUTHORS file	1 // Copyright (c) 2011, the Dart project authors. Please see the AUTHORS file

2 // for details. All rights reserved. Use of this source code is governed by a	2 // for details. All rights reserved. Use of this source code is governed by a

3 // BSD-style license that can be found in the LICENSE file.	3 // BSD-style license that can be found in the LICENSE file.

4	4

5 #include "vm/globals.h"	5 #include "vm/globals.h"

6 #if defined(TARGET_ARCH_X64)	6 #if defined(TARGET_ARCH_X64)

7	7

8 #include "vm/runtime_entry.h"	8 #include "vm/runtime_entry.h"

9	9

10 #include "vm/assembler.h"	10 #include "vm/assembler.h"

(...skipping 18 matching lines...) Expand all Loading...
29 if (is_leaf()) {	29 if (is_leaf()) {

30 ASSERT(argument_count == this->argument_count());	30 ASSERT(argument_count == this->argument_count());

31 COMPILE_ASSERT(CallingConventions::kVolatileCpuRegisters & (1 << RAX));	31 COMPILE_ASSERT(CallingConventions::kVolatileCpuRegisters & (1 << RAX));

32 __ movq(RAX, Address(THR, Thread::OffsetFromThread(this)));	32 __ movq(RAX, Address(THR, Thread::OffsetFromThread(this)));

33 __ CallCFunction(RAX);	33 __ CallCFunction(RAX);

34 } else {	34 } else {

35 // Argument count is not checked here, but in the runtime entry for a more	35 // Argument count is not checked here, but in the runtime entry for a more

36 // informative error message.	36 // informative error message.

37 __ movq(RBX, Address(THR, Thread::OffsetFromThread(this)));	37 __ movq(RBX, Address(THR, Thread::OffsetFromThread(this)));

38 __ movq(R10, Immediate(argument_count));	38 __ movq(R10, Immediate(argument_count));

39 __ Call(*StubCode::CallToRuntime_entry());	39 __ CallToRuntime();

40 }	40 }

41 }	41 }

42	42

43 } // namespace dart	43 } // namespace dart

44	44

45 #endif // defined TARGET_ARCH_X64	45 #endif // defined TARGET_ARCH_X64

OLD	NEW