ui/events/gesture_detection/gesture_configuration_android.cc - Issue 1778063002: Eliminate pinch drift by removing touch radius from span calculation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/events/gesture_detection/gesture_configuration_android.cc

Issue 1778063002: Eliminate pinch drift by removing touch radius from span calculation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Shrink minimum scale span. Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « ui/events/gesture_detection/gesture_configuration.cc ('k') | ui/events/gesture_detection/gesture_configuration_aura.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ui/events/gesture_detection/gesture_configuration_android.cc

diff --git a/ui/events/gesture_detection/gesture_configuration_android.cc b/ui/events/gesture_detection/gesture_configuration_android.cc

index 3b55b832a38a7022858eb7299af9e1aa3b5f33b8..1da5f454505203014d9dc40ba595d44d4c7cc51c 100644

--- a/ui/events/gesture_detection/gesture_configuration_android.cc

+++ b/ui/events/gesture_detection/gesture_configuration_android.cc

@@ -57,8 +57,6 @@ class GestureConfigurationAndroid : public GestureConfiguration {

set_min_pinch_update_span_delta(0.f);

set_min_scaling_span_in_pixels(

ViewConfiguration::GetMinScalingSpanInDips());

- set_min_scaling_touch_major(

- ViewConfiguration::GetMinScalingTouchMajorInDips());

set_show_press_delay_in_ms(ViewConfiguration::GetTapTimeoutInMs());

set_span_slop(ViewConfiguration::GetTouchSlopInDips() * 2.f);

set_fling_touchscreen_tap_suppression_enabled(true);

« no previous file with comments | « ui/events/gesture_detection/gesture_configuration.cc ('k') | ui/events/gesture_detection/gesture_configuration_aura.cc » ('j') | no next file with comments »