ui/events/gesture_detection/gesture_configuration.cc - Issue 1778063002: Eliminate pinch drift by removing touch radius from span calculation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/events/gesture_detection/gesture_configuration.cc

Issue 1778063002: Eliminate pinch drift by removing touch radius from span calculation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Shrink minimum scale span. Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « ui/events/gesture_detection/gesture_configuration.h ('k') | ui/events/gesture_detection/gesture_configuration_android.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ui/events/gesture_detection/gesture_configuration.cc

diff --git a/ui/events/gesture_detection/gesture_configuration.cc b/ui/events/gesture_detection/gesture_configuration.cc

index fbd46e297c30877c088d2a3557ee5e2a6e7f8fd5..037a5e7ca0e7bf4e56382b415462913887ed11da 100644

--- a/ui/events/gesture_detection/gesture_configuration.cc

+++ b/ui/events/gesture_detection/gesture_configuration.cc

@@ -53,8 +53,6 @@ GestureConfiguration::GestureConfiguration()

// If this is too small, we currently can get single finger pinch zoom.

// See crbug.com/357237 for details.

min_scaling_span_in_pixels_(125),

- // The default value of min_scaling_touch_major_ is 2 * default_radius_.

- min_scaling_touch_major_(50),

min_swipe_velocity_(20),

// TODO(jdduke): Disable and remove entirely when issues with intermittent

// scroll end detection on the Pixel are resolved, crbug.com/353702.