Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 177803003: [SVG] Make all C-macros used in the old property implementation NOOP. (Closed)

Created:
6 years, 9 months ago by kouhei (in TOK)
Modified:
6 years, 9 months ago
Reviewers:
haraken, pdr.
CC:
blink-reviews, Steve Block, krit, rjwright, alancutter (OOO until 2018), Mike Lawther (Google), fs, Timothy Loh, dstockwell, ed+blinkwatch_opera.com, shans, f(malita), gyuyoung.kim_webkit.org, darktears, Stephen Chennney, Eric Willigers, dino_apple.com, pdr., rwlbuis
Visibility:
Public.

Description

[SVG] Make all C-macros used in the old property implementation NOOP. This CL also removes all calls to |localAttributeToPropertyMap()| and |registerAnimatedPropertiesFor##OwnerType()|, the methods which were defined via the macros. This map was already empty, so no change in behavior. |SVGElement::cleanupAnimatedProperties()| contents are moved back to |~SVGElement()| again, as they were temporary workaround for the old SVGProperty implementation bug. BUG=308818 NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168587

Patch Set 1 #

Patch Set 2 : rebase #

Total comments: 6

Patch Set 3 : styles #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -185 lines) Patch
M Source/core/svg/SVGAElement.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/svg/SVGAltGlyphElement.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/svg/SVGAnimatedTypeAnimator.cpp View 1 2 chunks +2 lines, -3 lines 0 comments Download
M Source/core/svg/SVGAnimationElement.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/svg/SVGCircleElement.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/svg/SVGClipPathElement.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/svg/SVGComponentTransferFunctionElement.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/svg/SVGCursorElement.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/svg/SVGDefsElement.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/svg/SVGElement.h View 1 2 2 chunks +0 lines, -20 lines 0 comments Download
M Source/core/svg/SVGElement.cpp View 1 5 chunks +0 lines, -19 lines 0 comments Download
M Source/core/svg/SVGEllipseElement.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/svg/SVGFEBlendElement.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/svg/SVGFEColorMatrixElement.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/svg/SVGFEComponentTransferElement.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/svg/SVGFECompositeElement.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/svg/SVGFEConvolveMatrixElement.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/svg/SVGFEDiffuseLightingElement.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/svg/SVGFEDisplacementMapElement.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/svg/SVGFEDropShadowElement.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/svg/SVGFEGaussianBlurElement.cpp View 1 chunk +0 lines, -1 line 0 comments Download
Source/core/svg/SVGFEImageElement.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/svg/SVGFELightElement.cpp View 1 chunk +0 lines, -1 line 0 comments Download
Source/core/svg/SVGFEMergeNodeElement.cpp View 1 chunk +0 lines, -1 line 0 comments Download
Source/core/svg/SVGFEMorphologyElement.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/svg/SVGFEOffsetElement.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/svg/SVGFESpecularLightingElement.cpp View 1 chunk +0 lines, -1 line 0 comments Download
Source/core/svg/SVGFETileElement.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/svg/SVGFETurbulenceElement.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/svg/SVGFilterElement.cpp View 1 chunk +0 lines, -1 line 0 comments Download
Source/core/svg/SVGFilterPrimitiveStandardAttributes.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/svg/SVGFontElement.cpp View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/svg/SVGForeignObjectElement.cpp View 1 chunk +0 lines, -1 line 0 comments Download
Source/core/svg/SVGGElement.cpp View 1 chunk +0 lines, -1 line 0 comments Download
Source/core/svg/SVGGlyphRefElement.cpp View 1 chunk +0 lines, -1 line 0 comments Download
Source/core/svg/SVGGradientElement.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/svg/SVGGraphicsElement.cpp View 1 2 1 chunk +0 lines, -1 line 0 comments Download
Source/core/svg/SVGImageElement.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/svg/SVGLineElement.cpp View 1 chunk +0 lines, -1 line 0 comments Download
Source/core/svg/SVGLinearGradientElement.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/svg/SVGMPathElement.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/svg/SVGMarkerElement.cpp View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/svg/SVGMaskElement.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/svg/SVGPathElement.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/svg/SVGPatternElement.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/svg/SVGPolyElement.cpp View 1 chunk +0 lines, -1 line 0 comments Download
Source/core/svg/SVGRadialGradientElement.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/svg/SVGRectElement.cpp View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/svg/SVGSVGElement.cpp View 1 2 1 chunk +0 lines, -1 line 0 comments Download
Source/core/svg/SVGScriptElement.cpp View 1 chunk +0 lines, -1 line 0 comments Download
Source/core/svg/SVGStopElement.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/svg/SVGSwitchElement.cpp View 1 chunk +0 lines, -1 line 0 comments Download
Source/core/svg/SVGSymbolElement.cpp View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
Source/core/svg/SVGTextContentElement.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/svg/SVGTextPathElement.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/svg/SVGTextPositioningElement.cpp View 1 chunk +0 lines, -1 line 0 comments Download
Source/core/svg/SVGUseElement.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/svg/SVGViewElement.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/svg/properties/SVGAnimatedPropertyMacros.h View 1 1 chunk +7 lines, -84 lines 0 comments Download

Messages

Total messages: 18 (0 generated)
kouhei (in TOK)
Would you take a look? I'm trying to split the changes as much as possible. ...
6 years, 9 months ago (2014-02-27 07:11:58 UTC) #1
haraken
LGTM
6 years, 9 months ago (2014-02-27 09:16:27 UTC) #2
kouhei (in TOK)
The CQ bit was checked by kouhei@chromium.org
6 years, 9 months ago (2014-02-27 09:17:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kouhei@chromium.org/177803003/1
6 years, 9 months ago (2014-02-27 09:17:17 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-02-27 11:15:54 UTC) #5
commit-bot: I haz the power
Retried try job too often on mac_blink_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_blink_rel&number=20254
6 years, 9 months ago (2014-02-27 11:15:54 UTC) #6
kouhei (in TOK)
PTAL.
6 years, 9 months ago (2014-03-05 09:43:38 UTC) #7
haraken
LGTM https://codereview.chromium.org/177803003/diff/20001/Source/core/svg/SVGMarkerElement.cpp File Source/core/svg/SVGMarkerElement.cpp (right): https://codereview.chromium.org/177803003/diff/20001/Source/core/svg/SVGMarkerElement.cpp#newcode70 Source/core/svg/SVGMarkerElement.cpp:70: Nit: Unnecessary empty line. https://codereview.chromium.org/177803003/diff/20001/Source/core/svg/SVGRectElement.cpp File Source/core/svg/SVGRectElement.cpp (right): ...
6 years, 9 months ago (2014-03-05 14:05:26 UTC) #8
kouhei (in TOK)
https://codereview.chromium.org/177803003/diff/20001/Source/core/svg/SVGMarkerElement.cpp File Source/core/svg/SVGMarkerElement.cpp (right): https://codereview.chromium.org/177803003/diff/20001/Source/core/svg/SVGMarkerElement.cpp#newcode70 Source/core/svg/SVGMarkerElement.cpp:70: On 2014/03/05 14:05:27, haraken wrote: > > Nit: Unnecessary ...
6 years, 9 months ago (2014-03-06 01:55:13 UTC) #9
kouhei (in TOK)
The CQ bit was checked by kouhei@chromium.org
6 years, 9 months ago (2014-03-06 01:55:21 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kouhei@chromium.org/177803003/40001
6 years, 9 months ago (2014-03-06 01:55:56 UTC) #11
kouhei (in TOK)
The CQ bit was checked by kouhei@chromium.org
6 years, 9 months ago (2014-03-06 03:45:13 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kouhei@chromium.org/177803003/40001
6 years, 9 months ago (2014-03-06 03:45:51 UTC) #13
kouhei (in TOK)
The CQ bit was unchecked by kouhei@chromium.org
6 years, 9 months ago (2014-03-06 04:12:10 UTC) #14
kouhei (in TOK)
The CQ bit was checked by kouhei@chromium.org
6 years, 9 months ago (2014-03-06 04:12:17 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kouhei@chromium.org/177803003/40001
6 years, 9 months ago (2014-03-06 04:12:32 UTC) #16
kouhei (in TOK)
On 2014/03/06 04:12:17, kouhei wrote: > The CQ bit was checked by mailto:kouhei@chromium.org Stuck on ...
6 years, 9 months ago (2014-03-06 04:13:01 UTC) #17
commit-bot: I haz the power
6 years, 9 months ago (2014-03-06 08:00:14 UTC) #18
Message was sent while issue was closed. 
Change committed as 168587

Powered by Google App Engine
This is Rietveld 408576698