Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 1777943002: Remove unused function from BookmarkUtils. (Closed)

Created:
4 years, 9 months ago by dewittj
Modified:
4 years, 9 months ago
Reviewers:
Ted C, Ian Wen
CC:
chromium-reviews, noyau+watch_chromium.org, browser-components-watch_chromium.org, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unused function from BookmarkUtils. BUG= Committed: https://crrev.com/59dc57a2d8e823072c0ed7ac1c395df3dc8fdff2 Cr-Commit-Position: refs/heads/master@{#381024}

Patch Set 1 #

Patch Set 2 : Update tests as well. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -102 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkUtils.java View 1 chunk +0 lines, -29 lines 0 comments Download
M chrome/android/junit/src/org/chromium/chrome/browser/bookmarks/BookmarkUtilsTest.java View 1 3 chunks +0 lines, -73 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
dewittj
PTAL, this is simply dead code.
4 years, 9 months ago (2016-03-09 20:44:49 UTC) #2
dewittj
ping
4 years, 9 months ago (2016-03-12 00:08:59 UTC) #3
Ian Wen
lgtm. Sorry for the delay. I am a bit overloaded this week. :)
4 years, 9 months ago (2016-03-12 00:55:07 UTC) #4
Ian Wen
Weird enough I am not the owner for bookmark junit tests. You might need to ...
4 years, 9 months ago (2016-03-12 00:56:08 UTC) #5
dewittj
tedchoc: PTAL unit tests.
4 years, 9 months ago (2016-03-12 01:03:46 UTC) #7
Ted C
lgtm
4 years, 9 months ago (2016-03-14 17:51:40 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1777943002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1777943002/20001
4 years, 9 months ago (2016-03-14 17:53:34 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-14 18:43:34 UTC) #11
commit-bot: I haz the power
4 years, 9 months ago (2016-03-14 18:45:31 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/59dc57a2d8e823072c0ed7ac1c395df3dc8fdff2
Cr-Commit-Position: refs/heads/master@{#381024}

Powered by Google App Engine
This is Rietveld 408576698