Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3274)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkUtils.java

Issue 1777943002: Remove unused function from BookmarkUtils. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Update tests as well. Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/android/junit/src/org/chromium/chrome/browser/bookmarks/BookmarkUtilsTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkUtils.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkUtils.java b/chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkUtils.java
index faee49c00b0b27efecfd9f59f13d0d17521ab54d..95941a86479630b155ab5dc3aee0cb0f71a25d7f 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkUtils.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkUtils.java
@@ -96,35 +96,6 @@ public class BookmarkUtils {
return bookmarkModel.addBookmark(parent, bookmarkModel.getChildCount(parent), title, url);
}
- /**
- * Saves an offline copy for the specified tab that is bookmarked. A snackbar will be shown to
- * notify the user.
- * @param id The bookmark ID for the tab.
- * @param bookmarkModel The bookmark model.
- * @param tab The bookmarked tab to save an offline copy.
- * @param snackbarManager The SnackbarManager used to show the snackbar.
- * @param activity Current activity.
- */
- public static void saveBookmarkOffline(long id, BookmarkModel bookmarkModel,
- Tab tab, final SnackbarManager snackbarManager, Activity activity) {
- assert id != Tab.INVALID_BOOKMARK_ID;
- BookmarkId bookmarkId = new BookmarkId(id, BookmarkType.NORMAL);
-
- // Bail out if the ID no longer points to a valid bookmark, which might happen if the user
- // deleted the bookmark while the page was loading.
- if (!bookmarkModel.doesBookmarkExist(bookmarkId)) return;
-
- // Skip saving the offline page for the bookmark if the tab
- // cannot be saved currently (error or sad tab being shown).
- // TODO(sansid, petewil): Snackbar triggering for error tabs should be handled.
- // See: http://crbug/568310 for details.
- if (shouldSkipSavingTabOffline(tab)) return;
-
- bookmarkModel.saveOfflinePage(bookmarkId, tab.getWebContents(),
- createAddBookmarkCallback(bookmarkModel, snackbarManager, activity,
- tab.getWebContents()));
- }
-
private static void showSnackbarForAddingBookmark(final BookmarkModel bookmarkModel,
final SnackbarManager snackbarManager, final Activity activity,
final BookmarkId bookmarkId, final int saveResult, boolean isStorageAlmostFull,
« no previous file with comments | « no previous file | chrome/android/junit/src/org/chromium/chrome/browser/bookmarks/BookmarkUtilsTest.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698