content/browser/frame_host/navigator_impl.h - Issue 1777903003: Ensure the NavigationHandle's nav entry ID is updated during transfers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/navigator_impl.h

Issue 1777903003: Ensure the NavigationHandle's nav entry ID is updated during transfers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Move fix to another CL (now cleanup only) Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/frame_host/navigation_controller_impl_unittest.cc ('K') | « content/browser/frame_host/navigation_handle_impl.h ('k') | content/browser/frame_host/navigator_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/frame_host/navigator_impl.h

diff --git a/content/browser/frame_host/navigator_impl.h b/content/browser/frame_host/navigator_impl.h

index f8863516c1191f6582b6732e623458df12eb951f..5c44d95b90a7a593c253b07542c7e0f35e8052f6 100644

--- a/content/browser/frame_host/navigator_impl.h

+++ b/content/browser/frame_host/navigator_impl.h

@@ -135,7 +135,8 @@ class CONTENT_EXPORT NavigatorImpl : public Navigator {

// NavigationEntry if the controller does not currently have a

// browser-initiated one.

void DidStartMainFrameNavigation(const GURL& url,

- SiteInstanceImpl* site_instance);

+ SiteInstanceImpl* site_instance,

+ NavigationHandleImpl* navigation_handle);

// The NavigationController that will keep track of session history for all

// RenderFrameHost objects using this NavigatorImpl.