Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2377)

Unified Diff: content/browser/frame_host/navigation_handle_impl.h

Issue 1777903003: Ensure the NavigationHandle's nav entry ID is updated during transfers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Move fix to another CL (now cleanup only) Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/navigation_handle_impl.h
diff --git a/content/browser/frame_host/navigation_handle_impl.h b/content/browser/frame_host/navigation_handle_impl.h
index ba4190dd0c8206bd0c164e8f500b9123bda32435..71b5341f7cdcea14c8d1aa3349694835327e885b 100644
--- a/content/browser/frame_host/navigation_handle_impl.h
+++ b/content/browser/frame_host/navigation_handle_impl.h
@@ -126,6 +126,14 @@ class CONTENT_EXPORT NavigationHandleImpl : public NavigationHandle {
// will not have a NavigationEntry associated with it, and this will return 0.
int pending_nav_entry_id() const { return pending_nav_entry_id_; }
+ // Changes the pending NavigationEntry ID for this handle. This is currently
+ // required during transfer navigations.
+ // TODO(creis): Remove this when transfer navigations do not require pending
+ // entries. See https://crbug.com/495161.
+ void update_entry_id_for_transfer(int nav_entry_id) {
+ pending_nav_entry_id_ = nav_entry_id;
+ }
+
void set_net_error_code(net::Error net_error_code) {
net_error_code_ = net_error_code;
}
@@ -277,7 +285,7 @@ class CONTENT_EXPORT NavigationHandleImpl : public NavigationHandle {
const base::TimeTicks navigation_start_;
// The unique id of the corresponding NavigationEntry.
- const int pending_nav_entry_id_;
+ int pending_nav_entry_id_;
// This callback will be run when all throttle checks have been performed.
ThrottleChecksFinishedCallback complete_callback_;

Powered by Google App Engine
This is Rietveld 408576698