Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(673)

Issue 1777833002: Use Shadow DOM v1 APIs for Shadow DOM v1 tests (Closed)

Created:
4 years, 9 months ago by kochi
Modified:
4 years, 9 months ago
Reviewers:
hayato
CC:
blink-reviews, chromium-reviews, yuzuchan
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use Shadow DOM v1 APIs for Shadow DOM v1 tests Use Shadow DOM v1 APIs where possible for layout tests in //shadow-dom directory, e.g. Event.path -> Event.deepPath(), createShadowRoot({mode: 'open'}) -> attachShadow({mode: 'open'}). BUG=592371 Committed: https://crrev.com/b7e8e902064db5a974e0f2af8c10703b7ccf98b6 Cr-Commit-Position: refs/heads/master@{#380097}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -484 lines) Patch
A + third_party/WebKit/LayoutTests/shadow-dom/attach-shadow-with-parameter.html View 2 chunks +4 lines, -15 lines 1 comment Download
A + third_party/WebKit/LayoutTests/shadow-dom/attach-shadow-with-parameter-expected.txt View 1 chunk +2 lines, -4 lines 0 comments Download
D third_party/WebKit/LayoutTests/shadow-dom/create-shadow-root-with-parameter.html View 1 chunk +0 lines, -43 lines 0 comments Download
D third_party/WebKit/LayoutTests/shadow-dom/create-shadow-root-with-parameter-expected.txt View 1 chunk +0 lines, -16 lines 0 comments Download
A + third_party/WebKit/LayoutTests/shadow-dom/event-deeppath-closed-shadowroot.html View 5 chunks +10 lines, -10 lines 0 comments Download
A + third_party/WebKit/LayoutTests/shadow-dom/event-deeppath-closed-shadowroot-expected.txt View 1 chunk +5 lines, -5 lines 0 comments Download
A + third_party/WebKit/LayoutTests/shadow-dom/event-deeppath-closed-shadowroot2.html View 2 chunks +8 lines, -8 lines 0 comments Download
A + third_party/WebKit/LayoutTests/shadow-dom/event-deeppath-closed-shadowroot2-expected.txt View 2 chunks +6 lines, -6 lines 0 comments Download
A + third_party/WebKit/LayoutTests/shadow-dom/event-deeppath-with-slot.html View 3 chunks +3 lines, -3 lines 0 comments Download
D third_party/WebKit/LayoutTests/shadow-dom/event-path-closed-shadowroot.html View 1 chunk +0 lines, -79 lines 0 comments Download
D third_party/WebKit/LayoutTests/shadow-dom/event-path-closed-shadowroot-expected.txt View 1 chunk +0 lines, -29 lines 0 comments Download
D third_party/WebKit/LayoutTests/shadow-dom/event-path-closed-shadowroot2.html View 1 chunk +0 lines, -54 lines 0 comments Download
D third_party/WebKit/LayoutTests/shadow-dom/event-path-closed-shadowroot2-expected.txt View 1 chunk +0 lines, -34 lines 0 comments Download
D third_party/WebKit/LayoutTests/shadow-dom/event-path-with-slot.html View 1 chunk +0 lines, -84 lines 0 comments Download
M third_party/WebKit/LayoutTests/shadow-dom/get-destination-insertion-points.html View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/shadow-dom/get-destination-insertion-points-re-distribution.html View 5 chunks +4 lines, -9 lines 0 comments Download
A + third_party/WebKit/LayoutTests/shadow-dom/node-rootNode.html View 0 chunks +-1 lines, --1 lines 0 comments Download
D third_party/WebKit/LayoutTests/shadow-dom/treeRoot.html View 1 chunk +0 lines, -84 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1777833002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1777833002/1
4 years, 9 months ago (2016-03-09 05:43:29 UTC) #2
kochi
PTAL https://codereview.chromium.org/1777833002/diff/1/third_party/WebKit/LayoutTests/shadow-dom/attach-shadow-with-parameter.html File third_party/WebKit/LayoutTests/shadow-dom/attach-shadow-with-parameter.html (left): https://codereview.chromium.org/1777833002/diff/1/third_party/WebKit/LayoutTests/shadow-dom/attach-shadow-with-parameter.html#oldcode26 third_party/WebKit/LayoutTests/shadow-dom/attach-shadow-with-parameter.html:26: shouldBeNonNull(root3); This test does not make sense now ...
4 years, 9 months ago (2016-03-09 05:44:45 UTC) #4
hayato
lgtm
4 years, 9 months ago (2016-03-09 07:00:17 UTC) #5
hayato
lgtm
4 years, 9 months ago (2016-03-09 07:00:22 UTC) #6
hayato
lgtm
4 years, 9 months ago (2016-03-09 07:00:22 UTC) #7
hayato
lgtm
4 years, 9 months ago (2016-03-09 07:00:22 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1777833002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1777833002/1
4 years, 9 months ago (2016-03-09 07:01:35 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-09 07:49:26 UTC) #12
commit-bot: I haz the power
4 years, 9 months ago (2016-03-09 07:50:35 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b7e8e902064db5a974e0f2af8c10703b7ccf98b6
Cr-Commit-Position: refs/heads/master@{#380097}

Powered by Google App Engine
This is Rietveld 408576698