Chromium Code Reviews Chromium Code Reviews
Issue 1777833002:
Use Shadow DOM v1 APIs for Shadow DOM v1 tests (Closed)
Base URL: https://chromium.googlesource.com/chromium/src.git@master| Index: third_party/WebKit/LayoutTests/shadow-dom/attach-shadow-with-parameter.html |
| diff --git a/third_party/WebKit/LayoutTests/shadow-dom/create-shadow-root-with-parameter.html b/third_party/WebKit/LayoutTests/shadow-dom/attach-shadow-with-parameter.html |
| similarity index 67% |
| rename from third_party/WebKit/LayoutTests/shadow-dom/create-shadow-root-with-parameter.html |
| rename to third_party/WebKit/LayoutTests/shadow-dom/attach-shadow-with-parameter.html |
| index c371c24e440d3cafd929072cf3c3c213c65740cc..c61c06aacaba633dcc1b4c7ba2f9db1bcb0a3042 100644 |
| --- a/third_party/WebKit/LayoutTests/shadow-dom/create-shadow-root-with-parameter.html |
| +++ b/third_party/WebKit/LayoutTests/shadow-dom/attach-shadow-with-parameter.html |
| @@ -1,38 +1,28 @@ |
| <!doctype html> |
| -<html> |
| -<head> |
| <script src="../resources/js-test.js"></script> |
| <script src="../fast/dom/shadow/resources/shadow-dom.js"></script> |
| -</head> |
| <body> |
| <div id="host1"></div> |
| <div id="host2"></div> |
| <div id="host3"></div> |
| - <div id="host4"></div> |
| </body> |
| <script> |
| debug('Attach open shadow root.'); |
| var host1 = document.querySelector('#host1'); |
| -var root1 = host1.attachShadow({mode: 'open'}); |
| -shouldBeNonNull(root1); |
| +shouldBeNonNull("host1.attachShadow({mode: 'open'})"); |
| debug('Attach closed shadow root.'); |
| var host2 = document.querySelector('#host2'); |
| -shouldBeNonNull("host2.createShadowRoot({mode: 'closed'})"); |
| - |
| -debug('Create shadow root with empty parameter.'); |
| -var host3 = document.querySelector('#host3'); |
| -var root3 = host3.createShadowRoot({}); |
| -shouldBeNonNull(root3); |
|
kochi
2016/03/09 05:44:44
This test does not make sense now and removed.
|
| +shouldBeNonNull("host2.attachShadow({mode: 'closed'})"); |
| debug('Attach shadow root whose mode is neither open nor closed.'); |
| -var host4 = document.querySelector('#host4'); |
| +var host4 = document.querySelector('#host3'); |
| shouldThrow("host4.attachShadow({mode: 'illegal'})"); |
| debug('Attach open shadow root with shadow-dom.js utility.'); |
| document.body.appendChild( |
| createDOM('div', {id: 'host5'}, |
| - createShadowRoot({mode: 'open'}))); |
| + attachShadow({mode: 'open'}))); |
| var host5 = document.querySelector('#host5'); |
| var root5 = host5.shadowRoot; |
| shouldBeNonNull(root5); |
| @@ -40,4 +30,3 @@ shouldBeNonNull(root5); |
| debug('Attach shadow root on already shadowed host will raise InvalidStateError exception.'); |
| shouldThrow("host1.attachShadow({mode: 'open'})"); |
| </script> |
| -</html> |
