Define a few simple UMA metrics for the component updater.

Define a few simple UMA metrics for the component updater.
* number of updates
* number of installs (on-demand updates)
* completions success/error
* completion duration

BUG=593191
Committed: https://crrev.com/85953dcfa85e670b776e8389845a640ef6bb8fa4
Cr-Commit-Position: refs/heads/master@{#380272}

[Sorin Jianu, 2016-03-09 01:33:54]

The CQ bit was checked by sorin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-09 01:34:28]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1777793002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1777793002/1

[Sorin Jianu, 2016-03-09 01:35:39]

Description was changed from

==========
Define a few simple UMA metrics for the component updater.
* number of updates
* number of installs (on-demand updates)
* completions success/error
* completion duration

BUG=593191
==========

to

==========
Define a few simple UMA metrics for the component updater.
* number of updates
* number of installs (on-demand updates)
* completions success/error
* completion duration

BUG=593191
==========

[Sorin Jianu, 2016-03-09 01:35:40]

sorin@chromium.org changed reviewers:
+ isherman@chromium.org, waffles@chromium.org

[Sorin Jianu, 2016-03-09 01:37:45]

Ilya, please I need owners approval for the histogram changes.

Thank you!

[Ilya Sherman, 2016-03-09 02:28:01]

https://codereview.chromium.org/1777793002/diff/1/tools/metrics/histograms/hi...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/1777793002/diff/1/tools/metrics/histograms/hi...
tools/metrics/histograms/histograms.xml:5150: +<histogram
name="ComponentUpdater.Update.Count">
Would it make sense to combine the install and update counts in a single
enumerated histogram, with INSTALL and UPDATE buckets?  Alternately, would it
make sense to break down the Result histogram by whether the update was
triggered manually vs. automatically?

https://codereview.chromium.org/1777793002/diff/1/tools/metrics/histograms/hi...
tools/metrics/histograms/histograms.xml:5163: +<histogram
name="ComponentUpdater.UpdateCompleteTime" units="Ms">
nit: s/Ms/ms

[commit-bot: I haz the power, 2016-03-09 03:57:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-09 03:57:22]

Dry run: This issue passed the CQ dry run.

[waffles, 2016-03-09 17:10:40]

lgtm

[Sorin Jianu, 2016-03-09 19:51:43]

Thank you! PTAL.

https://codereview.chromium.org/1777793002/diff/1/tools/metrics/histograms/hi...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/1777793002/diff/1/tools/metrics/histograms/hi...
tools/metrics/histograms/histograms.xml:5150: +<histogram
name="ComponentUpdater.Update.Count">
On 2016/03/09 02:28:00, Ilya Sherman wrote:
> Would it make sense to combine the install and update counts in a single
> enumerated histogram, with INSTALL and UPDATE buckets?  Alternately, would it
> make sense to break down the Result histogram by whether the update was
> triggered manually vs. automatically?

I combined the Install and Update in one histogram.

https://codereview.chromium.org/1777793002/diff/1/tools/metrics/histograms/hi...
tools/metrics/histograms/histograms.xml:5163: +<histogram
name="ComponentUpdater.UpdateCompleteTime" units="Ms">
On 2016/03/09 02:28:00, Ilya Sherman wrote:
> nit: s/Ms/ms

Done.

[Ilya Sherman, 2016-03-09 20:13:50]

Metrics LGTM % nits:

https://codereview.chromium.org/1777793002/diff/20001/components/component_up...
File components/component_updater/component_updater_service.cc (right):

https://codereview.chromium.org/1777793002/diff/20001/components/component_up...
components/component_updater/component_updater_service.cc:253:
UMA_HISTOGRAM_ENUMERATION("ComponentUpdater.Calls.Count", 1, 2);
nit: I'd recommend defining a C++ enum, and emitting named values like
"UPDATE_TYPE_MANUAL" and "UPDATE_TYPE_AUTOMATED", and replacing "2" with
"UPDATE_TYPE_COUNT".

https://codereview.chromium.org/1777793002/diff/20001/components/component_up...
components/component_updater/component_updater_service.cc:253:
UMA_HISTOGRAM_ENUMERATION("ComponentUpdater.Calls.Count", 1, 2);
nit: I'd recommend having a wrapper function around the
UMA_HISTOGRAM_ENUMERATION macro, so that you only need to write the
"ComponentUpdater.Calls.Count" string in one place, and therefore it's harder to
typo the string in one code path and not the other.

https://codereview.chromium.org/1777793002/diff/20001/tools/metrics/histogram...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/1777793002/diff/20001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:5141: +<histogram
name="ComponentUpdater.Calls.Count" enum="ComponentUpdaterCalls">
nit: I'd drop the "Count" suffix at this point -- every histogram is counting
something =)

[Sorin Jianu, 2016-03-09 22:26:21]

thank you!

https://codereview.chromium.org/1777793002/diff/20001/components/component_up...
File components/component_updater/component_updater_service.cc (right):

https://codereview.chromium.org/1777793002/diff/20001/components/component_up...
components/component_updater/component_updater_service.cc:253:
UMA_HISTOGRAM_ENUMERATION("ComponentUpdater.Calls.Count", 1, 2);
On 2016/03/09 20:13:50, Ilya Sherman wrote:
> nit: I'd recommend having a wrapper function around the
> UMA_HISTOGRAM_ENUMERATION macro, so that you only need to write the
> "ComponentUpdater.Calls.Count" string in one place, and therefore it's harder
to
> typo the string in one code path and not the other.

Done.

https://codereview.chromium.org/1777793002/diff/20001/components/component_up...
components/component_updater/component_updater_service.cc:253:
UMA_HISTOGRAM_ENUMERATION("ComponentUpdater.Calls.Count", 1, 2);
On 2016/03/09 20:13:50, Ilya Sherman wrote:
> nit: I'd recommend having a wrapper function around the
> UMA_HISTOGRAM_ENUMERATION macro, so that you only need to write the
> "ComponentUpdater.Calls.Count" string in one place, and therefore it's harder
to
> typo the string in one code path and not the other.

Acknowledged.

https://codereview.chromium.org/1777793002/diff/20001/tools/metrics/histogram...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/1777793002/diff/20001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:5141: +<histogram
name="ComponentUpdater.Calls.Count" enum="ComponentUpdaterCalls">
On 2016/03/09 20:13:50, Ilya Sherman wrote:
> nit: I'd drop the "Count" suffix at this point -- every histogram is counting
> something =)

Done.

[Sorin Jianu, 2016-03-09 22:26:31]

The CQ bit was checked by sorin@chromium.org

[Sorin Jianu, 2016-03-09 22:26:32]

The patchset sent to the CQ was uploaded after l-g-t-m from
waffles@chromium.org, isherman@chromium.org
Link to the patchset: https://codereview.chromium.org/1777793002/#ps60001
(title: " ")

[commit-bot: I haz the power, 2016-03-09 22:27:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1777793002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1777793002/60001

[commit-bot: I haz the power, 2016-03-09 23:09:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-09 23:09:29]

Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Sorin Jianu, 2016-03-09 23:28:17]

The CQ bit was checked by sorin@chromium.org

[commit-bot: I haz the power, 2016-03-09 23:29:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1777793002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1777793002/60001

[commit-bot: I haz the power, 2016-03-10 00:32:56]

Description was changed from

==========
Define a few simple UMA metrics for the component updater.
* number of updates
* number of installs (on-demand updates)
* completions success/error
* completion duration

BUG=593191
==========

to

==========
Define a few simple UMA metrics for the component updater.
* number of updates
* number of installs (on-demand updates)
* completions success/error
* completion duration

BUG=593191
==========

[commit-bot: I haz the power, 2016-03-10 00:32:57]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-03-10 00:33:44]

Description was changed from

==========
Define a few simple UMA metrics for the component updater.
* number of updates
* number of installs (on-demand updates)
* completions success/error
* completion duration

BUG=593191
==========

to

==========
Define a few simple UMA metrics for the component updater.
* number of updates
* number of installs (on-demand updates)
* completions success/error
* completion duration

BUG=593191

Committed: https://crrev.com/85953dcfa85e670b776e8389845a640ef6bb8fa4
Cr-Commit-Position: refs/heads/master@{#380272}
==========

[commit-bot: I haz the power, 2016-03-10 00:33:45]

Patchset 4 (id:??) landed as
https://crrev.com/85953dcfa85e670b776e8389845a640ef6bb8fa4
Cr-Commit-Position: refs/heads/master@{#380272}