Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(392)

Unified Diff: components/component_updater/component_updater_service_internal.h

Issue 1777793002: Define a few simple UMA metrics for the component updater. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/component_updater/component_updater_service_internal.h
diff --git a/components/component_updater/component_updater_service_internal.h b/components/component_updater/component_updater_service_internal.h
index 29c5d31c844d917acbf8f686460dc1296f5804fc..3e262c0942a9b37ca3b15593d897839cc21678ae 100644
--- a/components/component_updater/component_updater_service_internal.h
+++ b/components/component_updater/component_updater_service_internal.h
@@ -17,6 +17,10 @@
#include "base/threading/thread_checker.h"
#include "components/component_updater/timer.h"
+namespace base {
+class TimeTicks;
+}
+
namespace component_updater {
class OnDemandUpdater;
@@ -44,13 +48,15 @@ class CrxUpdateService : public ComponentUpdateService,
void MaybeThrottle(const std::string& id,
const base::Closure& callback) override;
scoped_refptr<base::SequencedTaskRunner> GetSequencedTaskRunner() override;
- bool OnDemandUpdate(const std::string& id) override;
bool GetComponentDetails(const std::string& id,
CrxUpdateItem* item) const override;
// Overrides for Observer.
void OnEvent(Events event, const std::string& id) override;
+ // Overrides for OnDemandUpdater.
+ bool OnDemandUpdate(const std::string& id) override;
+
private:
void Start();
void Stop();
@@ -68,7 +74,7 @@ class CrxUpdateService : public ComponentUpdateService,
void OnUpdate(const std::vector<std::string>& ids,
std::vector<CrxComponent>* components);
- void OnUpdateComplete(int error);
+ void OnUpdateComplete(const base::TimeTicks& start_time, int error);
base::ThreadChecker thread_checker_;

Powered by Google App Engine
This is Rietveld 408576698