Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Unified Diff: Source/core/inspector/PromiseOfficer.h

Issue 177773002: Support Promises instrumentation on backend. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Address review comments + track Promise result Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/inspector/PromiseOfficer.h
diff --git a/Source/core/inspector/PromiseOfficer.h b/Source/core/inspector/PromiseOfficer.h
new file mode 100644
index 0000000000000000000000000000000000000000..94285a015adb82f90a0de747230dc464aefd946c
--- /dev/null
+++ b/Source/core/inspector/PromiseOfficer.h
@@ -0,0 +1,116 @@
+/*
+ * Copyright (C) 2014 Google Inc. All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions are
+ * met:
+ *
+ * * Redistributions of source code must retain the above copyright
+ * notice, this list of conditions and the following disclaimer.
+ * * Redistributions in binary form must reproduce the above
+ * copyright notice, this list of conditions and the following disclaimer
+ * in the documentation and/or other materials provided with the
+ * distribution.
+ * * Neither the name of Google Inc. nor the names of its
+ * contributors may be used to endorse or promote products derived from
+ * this software without specific prior written permission.
+ *
+ * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
+ * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
+ * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
+ * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
+ * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
+ * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
+ * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
+ * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
+ * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+ * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+ * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+ */
+
+#ifndef PromiseOfficer_h
+#define PromiseOfficer_h
+
+#include <v8.h>
+#include "bindings/v8/custom/V8PromiseCustom.h"
+#include "bindings/v8/ScopedPersistent.h"
+#include "bindings/v8/V8Binding.h"
+#include "core/dom/ExecutionContext.h"
+#include "wtf/HashMap.h"
+#include "wtf/Noncopyable.h"
+#include "wtf/RefPtr.h"
+#include "wtf/Vector.h"
+
+namespace WebCore {
+
+class PromiseOfficer {
+ WTF_MAKE_NONCOPYABLE(PromiseOfficer);
+public:
+ class PromiseData : public RefCounted<PromiseData> {
aandrey 2014/02/26 16:11:30 1) make it private 2) why RefCounted? remove it?
Alexandra Mikhaylova 2014/02/28 13:52:05 Done.
+ public:
+ PromiseData(v8::Handle<v8::Object> promise, v8::Handle<v8::Object> parentPromise, v8::Handle<v8::Value> result, V8PromiseCustom::PromiseState state, ExecutionContext* context)
+ : m_isolate(toIsolate(context))
+ , m_promise(m_isolate, promise)
+ , m_parentPromise(m_isolate, parentPromise)
+ , m_result(m_isolate, result)
+ , m_state(state)
+ { }
aandrey 2014/02/26 16:11:30 style: { }
Alexandra Mikhaylova 2014/02/28 13:52:05 Done.
+
+ v8::Handle<v8::Object> getPromise() {
aandrey 2014/02/26 16:11:30 style: "{" on the next line. also fix below
Alexandra Mikhaylova 2014/02/28 13:52:05 Done.
+ return m_promise.newLocal(m_isolate);
+ }
+
+ v8::Handle<v8::Object> getParentPromise() {
+ return m_parentPromise.newLocal(m_isolate);
+ }
+
+ v8::Handle<v8::Value> getResult() {
+ return m_result.newLocal(m_isolate);
+ }
+
+ V8PromiseCustom::PromiseState getState() {
+ return m_state;
+ }
+
+ private:
+ v8::Isolate* m_isolate;
+ ScopedPersistent<v8::Object> m_promise;
+ ScopedPersistent<v8::Object> m_parentPromise;
+ ScopedPersistent<v8::Value> m_result;
+ V8PromiseCustom::PromiseState m_state;
+ // TODO: maybe add m_scriptLocation or other label?
aandrey 2014/02/26 16:11:30 remove
Alexandra Mikhaylova 2014/02/28 13:52:05 Done.
+ };
+
+ PromiseOfficer()
+ : m_isEnabled(false)
+ { }
+
+ bool isEnabled() {
aandrey 2014/02/26 16:11:30 bool isEnabled() const { return m_isEnabled; }
Alexandra Mikhaylova 2014/02/28 13:52:05 Done.
+ return m_isEnabled;
+ }
+
+ void enable() {
aandrey 2014/02/26 16:11:30 move to cpp
Alexandra Mikhaylova 2014/02/28 13:52:05 Done.
+ m_isEnabled = true;
+ }
+
+ void disable() {
aandrey 2014/02/26 16:11:30 move to cpp
Alexandra Mikhaylova 2014/02/28 13:52:05 Done.
+ if (m_isEnabled) {
+ m_isEnabled = false;
+ m_promiseDataMap.clear();
Alexandra Mikhaylova 2014/02/26 14:11:51 Maybe disable() and clear() should be two differen
Alexandra Mikhaylova 2014/02/28 13:52:05 Done.
+ }
+ }
+
+ void addPromise(ExecutionContext* context, v8::Handle<v8::Object> promise, v8::Handle<v8::Object> parentPromise, V8PromiseCustom::PromiseState state);
+ void setPromiseParent(ExecutionContext* context, v8::Handle<v8::Object> promise, v8::Handle<v8::Object> parentPromise);
+ void setPromiseStateAndResult(ExecutionContext* context, v8::Handle<v8::Object> promise, v8::Handle<v8::Value> result, V8PromiseCustom::PromiseState state);
+
+private:
+ bool m_isEnabled;
+ typedef Vector<RefPtr<PromiseData> > PromiseDataVector;
aandrey 2014/02/26 16:11:30 Vector<PromiseData> + drop RefCounted
Alexandra Mikhaylova 2014/02/28 13:52:05 Done.
+ typedef HashMap<int, PromiseDataVector> PromiseDataMap;
+ PromiseDataMap m_promiseDataMap;
+};
+
+} // namespace WebCore
+
+#endif // !defined(PromiseOfficer_h)

Powered by Google App Engine
This is Rietveld 408576698