Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1119)

Unified Diff: Source/core/inspector/PromiseOfficer.cpp

Issue 177773002: Support Promises instrumentation on backend. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Address review comments + track Promise result Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/inspector/PromiseOfficer.cpp
diff --git a/Source/core/inspector/PromiseOfficer.cpp b/Source/core/inspector/PromiseOfficer.cpp
new file mode 100644
index 0000000000000000000000000000000000000000..fc6ddd96c07c0df71ef6c8a433e260206d908388
--- /dev/null
+++ b/Source/core/inspector/PromiseOfficer.cpp
@@ -0,0 +1,83 @@
+/*
+ * Copyright (C) 2014 Google Inc. All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions are
+ * met:
+ *
+ * * Redistributions of source code must retain the above copyright
+ * notice, this list of conditions and the following disclaimer.
+ * * Redistributions in binary form must reproduce the above
+ * copyright notice, this list of conditions and the following disclaimer
+ * in the documentation and/or other materials provided with the
+ * distribution.
+ * * Neither the name of Google Inc. nor the names of its
+ * contributors may be used to endorse or promote products derived from
+ * this software without specific prior written permission.
+ *
+ * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
+ * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
+ * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
+ * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
+ * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
+ * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
+ * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
+ * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
+ * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+ * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+ * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+ */
+
+#include "config.h"
+#include "core/inspector/PromiseOfficer.h"
+
+namespace WebCore {
+
+void PromiseOfficer::addPromise(ExecutionContext* context, v8::Handle<v8::Object> promise, v8::Handle<v8::Object> parentPromise, V8PromiseCustom::PromiseState state) {
aandrey 2014/02/26 16:11:30 style: "{" on new line
Alexandra Mikhaylova 2014/02/28 13:52:05 Done.
+ int promiseHash = promise->GetIdentityHash();
+ PromiseDataMap::iterator it = m_promiseDataMap.find(promiseHash);
+ if (it != m_promiseDataMap.end()) {
+ PromiseDataVector& vector = it->value;
+ for (size_t index = 0; index < vector.size(); index++) {
aandrey 2014/02/26 16:11:30 remove or guard with "#ifndef NDEBUG"
Alexandra Mikhaylova 2014/02/28 13:52:05 Done.
+ RefPtr<PromiseData> data = vector.at(index);
+ ASSERT(data->getPromise() != promise); // Because we add a new promise (and don't update existing ones).
+ }
+ vector.append(adoptRef(new PromiseData(promise, parentPromise, v8::Undefined(toIsolate(context)), state, context)));
+ } else {
+ PromiseDataVector vector;
+ vector.append(adoptRef(new PromiseData(promise, parentPromise, v8::Undefined(toIsolate(context)), state, context)));
aandrey 2014/02/26 16:11:30 we can remove code dup: PromiseDataVector* vector
Alexandra Mikhaylova 2014/02/28 13:52:05 Done.
+ m_promiseDataMap.set(promiseHash, vector);
+ }
+}
+
+void PromiseOfficer::setPromiseParent(ExecutionContext* context, v8::Handle<v8::Object> promise, v8::Handle<v8::Object> parentPromise) {
+ int promiseHash = promise->GetIdentityHash();
+ PromiseDataMap::iterator it = m_promiseDataMap.find(promiseHash);
+ ASSERT(it != m_promiseDataMap.end()); // This must be a promise that's already been tracked.
aandrey 2014/02/26 16:11:30 we may be activated after a web page was loaded
Alexandra Mikhaylova 2014/02/28 13:52:05 Done, removed ASSERT.
+ PromiseDataVector& vector = it->value;
+ for (size_t index = 0; index < vector.size(); index++) {
+ RefPtr<PromiseData> data = vector.at(index);
+ if (data->getPromise() == promise && data->getParentPromise() != parentPromise) {
aandrey 2014/02/26 16:11:30 remove: data->getParentPromise() != parentPromise
Alexandra Mikhaylova 2014/02/28 13:52:05 Done.
+ vector.remove(index);
+ vector.append(adoptRef(new PromiseData(promise, parentPromise, data->getResult(), data->getState(), context)));
aandrey 2014/02/26 16:11:30 just update the parent
Alexandra Mikhaylova 2014/02/28 13:52:05 Done.
+ break;
+ }
+ }
+}
+
+void PromiseOfficer::setPromiseStateAndResult(ExecutionContext* context, v8::Handle<v8::Object> promise, v8::Handle<v8::Value> result, V8PromiseCustom::PromiseState state) {
+ int promiseHash = promise->GetIdentityHash();
+ PromiseDataMap::iterator it = m_promiseDataMap.find(promiseHash);
+ ASSERT(it != m_promiseDataMap.end()); // This must be a promise that's already been tracked.
aandrey 2014/02/26 16:11:30 ditto
Alexandra Mikhaylova 2014/02/28 13:52:05 Done.
+ PromiseDataVector& vector = it->value;
+ for (size_t index = 0; index < vector.size(); index++) {
+ RefPtr<PromiseData> data = vector.at(index);
+ if (data->getPromise() == promise && data->getState() != state) {
aandrey 2014/02/26 16:11:30 remove: data->getState() != state
Alexandra Mikhaylova 2014/02/28 13:52:05 Done.
+ vector.remove(index);
+ vector.append(adoptRef(new PromiseData(promise, data->getParentPromise(), result, state, context)));
aandrey 2014/02/26 16:11:30 just update
Alexandra Mikhaylova 2014/02/28 13:52:05 Done.
+ break;
+ }
+ }
+}
+
+} // namespace WebCore
« Source/core/inspector/PromiseOfficer.h ('K') | « Source/core/inspector/PromiseOfficer.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698