Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1777693002:
Enable git-cl-land for git-cache checkouts. (Closed)
|
Created:
4 years, 9 months ago by szager1 Modified:
4 years, 9 months ago CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org Target Ref:
refs/heads/master Project:
depot_tools Visibility:
Public. |
DescriptionEnable git-cl-land for git-cache checkouts.
The key piece here is that when running 'git cl land' from a cache checkout, refs/pending/* must be fetched from / pushed to the cache mirror's remote.
BUG=589140
R=wkorman,agable,iannucci,martiniss
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=299166
Patch Set 1 #Patch Set 2 : set git_cache.Mirror.cachepath #
Total comments: 1
Messages
Total messages: 19 (8 generated)
Description was changed from ========== Enable git-cl-land for git-cache checkouts. BUG=589140 R=wkorman,agable,iannucci,martiniss ========== to ========== Enable git-cl-land for git-cache checkouts. The key piece here is that when running 'git cl land' from a cache checkout, refs/pending/* must be fetched from / pushed to the cache mirror's remote. BUG=589140 R=wkorman,agable,iannucci,martiniss ==========
agable@chromium.org changed reviewers: + tandrii@chromium.org
LGTM, this looks sane. I also wish this had tests, but that's not your fault :( Also, +tandrii as he has made the most changes to git-cl lately.
The CQ bit was checked by szager@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1777693002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1777693002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: Depot Tools Presubmit on tryserver.infra (JOB_FAILED, https://build.chromium.org/p/tryserver.infra/builders/Depot%20Tools%20Presubm...)
lgtm
The CQ bit was checked by szager@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from agable@chromium.org, wkorman@chromium.org Link to the patchset: https://codereview.chromium.org/1777693002/#ps20001 (title: "set git_cache.Mirror.cachepath")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1777693002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1777693002/20001
Message was sent while issue was closed.
Description was changed from ========== Enable git-cl-land for git-cache checkouts. The key piece here is that when running 'git cl land' from a cache checkout, refs/pending/* must be fetched from / pushed to the cache mirror's remote. BUG=589140 R=wkorman,agable,iannucci,martiniss ========== to ========== Enable git-cl-land for git-cache checkouts. The key piece here is that when running 'git cl land' from a cache checkout, refs/pending/* must be fetched from / pushed to the cache mirror's remote. BUG=589140 R=wkorman,agable,iannucci,martiniss Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=299166 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as http://src.chromium.org/viewvc/chrome?view=rev&revision=299166
Message was sent while issue was closed.
smut@google.com changed reviewers: + smut@google.com
Message was sent while issue was closed.
https://codereview.chromium.org/1777693002/diff/20001/git_cl.py File git_cl.py (right): https://codereview.chromium.org/1777693002/diff/20001/git_cl.py#newcode634 git_cl.py:634: local_url = RunGit(['remote', 'get-url', remote]).strip() "git remote get-url" is not available in all versions of git, and this is causing failures for iOS now (https://crbug.com/593279). Can you change this to "git config remote.<remote>.url"?
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/1782683002/ by smut@google.com. The reason for reverting is: Causing iOS autoroller to fail..
Message was sent while issue was closed.
On 2016/03/09 22:20:20, smut wrote: > A revert of this CL (patchset #2 id:20001) has been created in > https://codereview.chromium.org/1782683002/ by mailto:smut@google.com. > > The reason for reverting is: Causing iOS autoroller to fail.. Never mind, this was fixed in https://codereview.chromium.org/1777043002. |
