Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1777043002:
Don't use 'git remote get-url', which is a new-ish feature. (Closed)
|
Created:
4 years, 9 months ago by szager1 Modified:
4 years, 9 months ago CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org Target Ref:
refs/heads/master Project:
depot_tools Visibility:
Public. |
DescriptionDon't use 'git remote get-url', which is a new-ish feature.
Apparently most Mac's have git 2.6.2, which doesn't have this
feature.
This only affects end developers, so there's no urgency to push
this out to the bots.
TBR=agable@chromium.org,wkorman@chromium.org
BUG=
NOTRY=true
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=299185
Patch Set 1 #Messages
Total messages: 19 (8 generated)
The CQ bit was checked by szager@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1777043002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1777043002/1
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full committers or once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. Committers are members of the group "project-infra-committers". Note that this has nothing to do with OWNERS files.
Description was changed from ========== Don't use 'git remote get-url', which is a new-ish feature. Apparently most Mac's have git 2.6.2, which doesn't have this feature. This only affects end developers, so there's no urgency to push this out to the bots. TBR=agable@chromium.org,wkorman@chromium.org BUG= ========== to ========== Don't use 'git remote get-url', which is a new-ish feature. Apparently most Mac's have git 2.6.2, which doesn't have this feature. This only affects end developers, so there's no urgency to push this out to the bots. TBR=agable@chromium.org,wkorman@chromium.org BUG= NOTRY=true ==========
The CQ bit was checked by szager@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1777043002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1777043002/1
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full committers or once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. Committers are members of the group "project-infra-committers". Note that this has nothing to do with OWNERS files.
lgtm
On 2016/03/09 20:17:45, szager1 wrote: > lgtm Oh, hmm, I guess I'm not in project-infra-committers. agable@, please to review?
dpranke@chromium.org changed reviewers: + dpranke@chromium.org
lgtm
The CQ bit was checked by szager@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1777043002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1777043002/1
Message was sent while issue was closed.
Description was changed from ========== Don't use 'git remote get-url', which is a new-ish feature. Apparently most Mac's have git 2.6.2, which doesn't have this feature. This only affects end developers, so there's no urgency to push this out to the bots. TBR=agable@chromium.org,wkorman@chromium.org BUG= NOTRY=true ========== to ========== Don't use 'git remote get-url', which is a new-ish feature. Apparently most Mac's have git 2.6.2, which doesn't have this feature. This only affects end developers, so there's no urgency to push this out to the bots. TBR=agable@chromium.org,wkorman@chromium.org BUG= NOTRY=true Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=299185 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as http://src.chromium.org/viewvc/chrome?view=rev&revision=299185
Message was sent while issue was closed.
lgtm |
