Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(275)

Issue 1777473004: Use password_manager::metrics_util::ResponseType on iOS (Closed)

Created:
4 years, 9 months ago by vabr (Chromium)
Modified:
4 years, 9 months ago
Reviewers:
dvadym
CC:
chromium-reviews, sdefresne+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use password_manager::metrics_util::ResponseType on iOS The passwords infobar delegate had a separate copy of the ResponseType enum. So far it had a subset of values of the desktop version of ResponseType (matching the positions), so it was not a problem, but to avoid diverging in the future, this CL switches the iOS code to use the component-defined ResponseType (which also matches histograms.xml). R=melandory@chromium.org BUG=593295 Committed: https://crrev.com/0090ffb1c2878f85bd94750db07c09448741172b Cr-Commit-Position: refs/heads/master@{#380132}

Patch Set 1 #

Patch Set 2 : Fix compile #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -12 lines) Patch
M ios/chrome/browser/passwords/ios_chrome_save_password_infobar_delegate.h View 3 chunks +2 lines, -8 lines 0 comments Download
M ios/chrome/browser/passwords/ios_chrome_save_password_infobar_delegate.mm View 1 2 chunks +5 lines, -4 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 9 (3 generated)
vabr (Chromium)
Hello melandory@, Please have a look. Cheers, Vaclav
4 years, 9 months ago (2016-03-09 12:59:07 UTC) #1
vabr (Chromium)
I forgot that melandory@ is OOO today. Vadym, could you PTAL? Thanks, Vaclav
4 years, 9 months ago (2016-03-09 13:34:32 UTC) #3
dvadym
On 2016/03/09 13:34:32, vabr (Chromium) wrote: > I forgot that melandory@ is OOO today. > ...
4 years, 9 months ago (2016-03-09 13:42:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1777473004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1777473004/20001
4 years, 9 months ago (2016-03-09 13:46:12 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-09 14:07:13 UTC) #7
commit-bot: I haz the power
4 years, 9 months ago (2016-03-09 14:08:26 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/0090ffb1c2878f85bd94750db07c09448741172b
Cr-Commit-Position: refs/heads/master@{#380132}

Powered by Google App Engine
This is Rietveld 408576698