third_party/WebKit/Source/core/dom/Microtask.cpp - Issue 1777183002: Revert of Use v8::MicrotasksScope internally in V8RecursionScope.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/Microtask.cpp

Issue 1777183002: Revert of Use v8::MicrotasksScope internally in V8RecursionScope. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@v8rs-2-endofscope

Patch Set: Resolve patch conflict Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/V8RecursionScope.cpp ('k') | third_party/WebKit/Source/core/streams/ReadableStreamReaderTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/dom/Microtask.cpp

diff --git a/third_party/WebKit/Source/core/dom/Microtask.cpp b/third_party/WebKit/Source/core/dom/Microtask.cpp

index 344c9e0181de1aa5f0e4ca1fb1ccbc0eb3210db9..7c3ec6ed7540cddc51fed0809c5873375a2df5be 100644

--- a/third_party/WebKit/Source/core/dom/Microtask.cpp

+++ b/third_party/WebKit/Source/core/dom/Microtask.cpp

@@ -40,9 +40,13 @@ namespace blink {

void Microtask::performCheckpoint(v8::Isolate* isolate)

{

- if (ScriptForbiddenScope::isScriptForbidden())

+ V8PerIsolateData* isolateData = V8PerIsolateData::from(isolate);

+ ASSERT(isolateData);

+ if (isolateData->recursionLevel() || isolateData->performingMicrotaskCheckpoint() || isolateData->destructionPending() || ScriptForbiddenScope::isScriptForbidden())

return;

- v8::MicrotasksScope::PerformCheckpoint(isolate);

+ isolateData->setPerformingMicrotaskCheckpoint(true);

+ isolate->RunMicrotasks();

+ isolateData->setPerformingMicrotaskCheckpoint(false);

}

static void microtaskFunctionCallback(void* data)