Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 177713006: Revert 251563 "Move browser initiated navigation from RenderView..." (Closed)

Created:
6 years, 10 months ago by Charlie Reis
Modified:
6 years, 10 months ago
Reviewers:
nasko
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 251563 "Move browser initiated navigation from RenderView..." Speculatively revert to help diagnose bug 345757. Mainly useful to make it easier to revert r249676, which changes the lifetime of RenderViewHosts. > Move browser initiated navigation from RenderViewHost to RenderFrameHost. > > BUG=304341 > TBR=jochen@chromium.org > > Review URL: https://codereview.chromium.org/148083013 TBR=nasko@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=253010

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+527 lines, -623 lines) Patch
M trunk/src/chrome/test/chromedriver/chrome/navigation_tracker.cc View 1 chunk +6 lines, -8 lines 0 comments Download
M trunk/src/content/browser/frame_host/navigation_controller_impl_unittest.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M trunk/src/content/browser/frame_host/navigator_impl.cc View 3 chunks +12 lines, -12 lines 0 comments Download
M trunk/src/content/browser/frame_host/render_frame_host_impl.h View 2 chunks +0 lines, -13 lines 0 comments Download
M trunk/src/content/browser/frame_host/render_frame_host_impl.cc View 2 chunks +0 lines, -62 lines 0 comments Download
M trunk/src/content/browser/frame_host/render_frame_host_manager_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M trunk/src/content/browser/renderer_host/render_view_host_impl.h View 8 chunks +4 lines, -16 lines 0 comments Download
M trunk/src/content/browser/renderer_host/render_view_host_impl.cc View 2 chunks +58 lines, -5 lines 0 comments Download
D trunk/src/content/common/frame_message_enums.h View 1 chunk +0 lines, -40 lines 0 comments Download
M trunk/src/content/common/frame_messages.h View 4 chunks +0 lines, -99 lines 0 comments Download
M trunk/src/content/common/view_message_enums.h View 1 chunk +27 lines, -0 lines 0 comments Download
M trunk/src/content/common/view_messages.h View 3 chunks +97 lines, -0 lines 0 comments Download
M trunk/src/content/content_common.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M trunk/src/content/public/test/render_view_test.cc View 3 chunks +7 lines, -8 lines 0 comments Download
M trunk/src/content/renderer/accessibility/renderer_accessibility_browsertest.cc View 4 chunks +4 lines, -9 lines 0 comments Download
M trunk/src/content/renderer/devtools/devtools_agent.cc View 2 chunks +1 line, -2 lines 0 comments Download
M trunk/src/content/renderer/notification_provider.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M trunk/src/content/renderer/render_frame_impl.h View 2 chunks +0 lines, -5 lines 0 comments Download
M trunk/src/content/renderer/render_frame_impl.cc View 7 chunks +2 lines, -252 lines 0 comments Download
M trunk/src/content/renderer/render_view_browsertest.cc View 18 chunks +49 lines, -53 lines 0 comments Download
M trunk/src/content/renderer/render_view_impl.h View 6 chunks +7 lines, -12 lines 0 comments Download
M trunk/src/content/renderer/render_view_impl.cc View 8 chunks +243 lines, -15 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Charlie Reis
6 years, 10 months ago (2014-02-24 22:30:53 UTC) #1
Charlie Reis
6 years, 10 months ago (2014-02-24 22:33:22 UTC) #2
Message was sent while issue was closed. 
Committed patchset #1 manually as r253010.

Powered by Google App Engine
This is Rietveld 408576698