Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(356)

Unified Diff: trunk/src/content/renderer/render_view_impl.h

Issue 177713006: Revert 251563 "Move browser initiated navigation from RenderView..." (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: trunk/src/content/renderer/render_view_impl.h
===================================================================
--- trunk/src/content/renderer/render_view_impl.h (revision 253009)
+++ trunk/src/content/renderer/render_view_impl.h (working copy)
@@ -75,7 +75,7 @@
class PepperDeviceTest;
class SkBitmap;
struct PP_NetAddress_Private;
-struct FrameMsg_Navigate_Params;
+struct ViewMsg_Navigate_Params;
struct ViewMsg_PostMessage_Params;
struct ViewMsg_StopFinding_Params;
@@ -804,14 +804,14 @@
CONNECTION_ERROR,
};
- static bool IsReload(const FrameMsg_Navigate_Params& params);
+ static blink::WebReferrerPolicy GetReferrerPolicyFromRequest(
+ blink::WebFrame* frame,
+ const blink::WebURLRequest& request);
static Referrer GetReferrerFromRequest(
blink::WebFrame* frame,
const blink::WebURLRequest& request);
- static void NotifyTimezoneChange(blink::WebFrame* frame);
-
void UpdateTitle(blink::WebFrame* frame, const base::string16& title,
blink::WebTextDirection title_direction);
void UpdateSessionHistory(blink::WebFrame* frame);
@@ -924,6 +924,7 @@
void OnPluginActionAt(const gfx::Point& location,
const blink::WebPluginAction& action);
void OnMoveOrResizeStarted();
+ void OnNavigate(const ViewMsg_Navigate_Params& params);
void OnPostMessageEvent(const ViewMsg_PostMessage_Params& params);
void OnReleaseDisambiguationPopupDIB(TransportDIB::Handle dib_handle);
void OnReloadFrame();
@@ -1024,13 +1025,9 @@
// Returns true if the |params| navigation is to an entry that has been
// cropped due to a recent navigation the browser did not know about.
- bool IsBackForwardToStaleEntry(const FrameMsg_Navigate_Params& params,
+ bool IsBackForwardToStaleEntry(const ViewMsg_Navigate_Params& params,
bool is_reload);
- // TODO(nasko): Remove this method when code is migrated to use
- // RenderFrameObserver.
- void OnNavigate(const FrameMsg_Navigate_Params& params);
-
// Make this RenderView show an empty, unscriptable page.
void NavigateToSwappedOutURL(blink::WebFrame* frame);
@@ -1162,7 +1159,6 @@
bool is_loading_;
// The gesture that initiated the current navigation.
- // TODO(nasko): Move to RenderFrame, as this is per-frame state.
NavigationGesture navigation_gesture_;
// Used for popups.
@@ -1182,8 +1178,7 @@
// the WebDataSource::ExtraData attribute. We use pending_navigation_state_
// as a temporary holder for the state until the WebDataSource corresponding
// to the new navigation is created. See DidCreateDataSource.
- // TODO(nasko): Move to RenderFrame, as this is per-frame state.
- scoped_ptr<FrameMsg_Navigate_Params> pending_navigation_params_;
+ scoped_ptr<ViewMsg_Navigate_Params> pending_navigation_params_;
// Timer used to delay the updating of nav state (see SyncNavigationState).
base::OneShotTimer<RenderViewImpl> nav_state_sync_timer_;
« no previous file with comments | « trunk/src/content/renderer/render_view_browsertest.cc ('k') | trunk/src/content/renderer/render_view_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698