Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1777083002: Make QuicSimpleServerStream supports multipart response body (Closed)

Created:
4 years, 9 months ago by xunjieli
Modified:
4 years, 9 months ago
Reviewers:
mef, Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org, rjshade
Base URL:
https://chromium.googlesource.com/chromium/src.git@quicsmaller
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make QuicSimpleServerStream supports multipart response body This CL modifies QuicInMemoryCache and QuicSimpleServerStream, so that multipart response body is supported. Also added Cronet tests to make sure the server works as expected. BUG=584338

Patch Set 1 : #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+322 lines, -59 lines) Patch
M components/cronet/android/cronet_bidirectional_stream_adapter.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M components/cronet/android/test/javatests/src/org/chromium/net/TestBidirectionalStreamCallback.java View 1 chunk +1 line, -0 lines 0 comments Download
M components/cronet/android/test/quic_test_server.cc View 2 chunks +26 lines, -0 lines 0 comments Download
M components/cronet/android/test/src/org/chromium/net/QuicTestServer.java View 3 chunks +48 lines, -0 lines 0 comments Download
M net/tools/quic/end_to_end_test.cc View 1 2 2 chunks +42 lines, -1 line 0 comments Download
M net/tools/quic/quic_in_memory_cache.h View 1 2 6 chunks +23 lines, -0 lines 0 comments Download
M net/tools/quic/quic_in_memory_cache.cc View 3 chunks +30 lines, -1 line 0 comments Download
M net/tools/quic/quic_simple_server_stream.h View 4 chunks +22 lines, -8 lines 0 comments Download
M net/tools/quic/quic_simple_server_stream.cc View 6 chunks +126 lines, -49 lines 0 comments Download

Messages

Total messages: 5 (3 generated)
xunjieli
Ryan: PTAL at net/* Misha: PTAL at cronet/*. Robbie: Please advice if you have time. ...
4 years, 9 months ago (2016-03-09 22:18:35 UTC) #4
Ryan Hamilton
4 years, 9 months ago (2016-03-09 22:33:48 UTC) #5 
On 2016/03/09 22:18:35, xunjieli wrote:
> Ryan: PTAL at net/*
> Misha: PTAL at cronet/*.
> Robbie: Please advice if you have time.
> 
> Thanks!

Instead of doing this work in Chromium, can you land an internal CL to do this
and we'll merge it to chrome?

Powered by Google App Engine
This is Rietveld 408576698