Make QuicSimpleServerStream supports multipart response body

net/tools/quic/end_to_end_test.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <stddef.h>
 #include <sys/epoll.h>
 #include <string>
 #include <vector>
 
 #include "base/memory/scoped_ptr.h"
@@ skipping 1930 matching lines @@
       : QuicSimpleServerStream(id, session), response_body_(response_body) {}
 
   ~ServerStreamWithErrorResponseBody() override {}
 
  protected:
   void SendErrorResponse() override {
     DVLOG(1) << "Sending error response for stream " << id();
     SpdyHeaderBlock headers;
     headers[":status"] = "500";
     headers["content-length"] = base::UintToString(response_body_.size());
+    response_.set_headers(headers);
+    response_.set_body(response_body_);
     // This method must call CloseReadSide to cause the test case, StopReading
     // is not sufficient.
     ReliableQuicStreamPeer::CloseReadSide(this);
-    SendHeadersAndBody(headers, response_body_);
+    next_state_ = SEND_HEADERS;
+    DoLoop();
   }
 
   string response_body_;
 };
 
 class StreamWithErrorFactory : public QuicTestServer::StreamFactory {
  public:
   explicit StreamWithErrorFactory(string response_body)
       : response_body_(response_body) {}
 
@@ skipping 148 matching lines @@
   trailers["some-trailing-header"] = "trailing-header-value";
 
   QuicInMemoryCache::GetInstance()->AddResponse(
       "www.google.com", "/trailer_url", headers, kBody, trailers);
 
   EXPECT_EQ(kBody, client_->SendSynchronousRequest("/trailer_url"));
   EXPECT_EQ(200u, client_->response_headers()->parsed_response_code());
   EXPECT_EQ(trailers, client_->response_trailers());
 }
 
+TEST_P(EndToEndTest, MultipartResponse) {
+  // Test QuicInMemoryCache::AddBidirectionalResponse with multipart response
+  // body works. However, this does not have full coverage since the client only
+  // supports request/response and not bidirectional streaming.
+  ASSERT_TRUE(Initialize());
+  client_->client()->WaitForCryptoHandshakeConfirmed();
+
+  // Set reordering to ensure that Trailers arriving before body is ok.
+  SetPacketSendDelay(QuicTime::Delta::FromMilliseconds(2));
+  SetReorderPercentage(30);
+
+  // Add a response with headers, body, and trailers.
+  const string kBody = "body content";
+
+  SpdyHeaderBlock headers;
+  headers[":status"] = "200";
+  headers[":version"] = "HTTP/1.1";
+  headers["content-length"] = IntToString(kBody.size());
+
+  SpdyHeaderBlock trailers;
+  trailers["some-trailing-header"] = "trailing-header-value";
+  std::vector<std::string> multipart_body;
+  multipart_body.push_back("hellooo!");
+  multipart_body.push_back("here's my second part.");
+  multipart_body.push_back("here's my third part.");
+
+  QuicInMemoryCache::GetInstance()->AddBidirectionalResponse(
+      "www.google.com", "/trailer_url", 200, multipart_body, trailers);
+
+  std::string expected;
+  for (auto s : multipart_body) {
+    expected.append(s);
+  }
+  EXPECT_EQ(expected, client_->SendSynchronousRequest("/trailer_url"));
+  EXPECT_EQ(200u, client_->response_headers()->parsed_response_code());
+  EXPECT_EQ(trailers, client_->response_trailers());
+}
+
 class EndToEndTestServerPush : public EndToEndTest {
  protected:
   const size_t kNumMaxStreams = 10;
 
   EndToEndTestServerPush() : EndToEndTest() {
     FLAGS_quic_supports_push_promise = true;
     FLAGS_quic_different_max_num_open_streams = true;
     client_config_.SetMaxStreamsPerConnection(kNumMaxStreams, kNumMaxStreams);
   }
 
@@ skipping 233 matching lines @@
   // sending requests for them.
   EXPECT_EQ(1u, client_->num_requests());
   // Including response to original request, 12 responses in total were
   // recieved.
   EXPECT_EQ(12u, client_->num_responses());
 }
 
 }  // namespace
 }  // namespace test
 }  // namespace net