[SVG] Remove SVGAnimatedPropertyMacros.h

[SVG] Remove SVGAnimatedPropertyMacros.h

These C macros are for the old SVGAnimatedProperty implementation.
We introduced new animated property implementation in crbug.com/308818 , so they are no longer used.

BUG=349370
NOTRY=true

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168613

[kouhei (in TOK), 2014-03-05 10:17:22]

More cleanups. https://codereview.chromium.org/177803003/ needs to be landed
first.

Changes in SVG*Element.{h,cpp} are automatically generated from sed.

sed -i '/BEGIN_REGISTER_ANIMATED_PROPERTIES/d' `find . -name \*.cpp -or -name
\*.h -type f`
sed -i '/END_REGISTER_ANIMATED_PROPERTIES/d' `find . -name \*.cpp -or -name \*.h
-type f`
sed -i '/BEGIN_DECLARE_ANIMATED_PROPERTIES/d' `find . -name \*.cpp -or -name
\*.h -type f`
sed -i '/END_DECLARE_ANIMATED_PROPERTIES/d' `find . -name \*.cpp -or -name \*.h
-type f`
sed -i '/REGISTER_LOCAL_ANIMATED_PROPERTY/d' `find . -name \*.cpp -or -name \*.h
-type f`
sed -i '/REGISTER_PARENT_ANIMATED_PROPERTIES/d' `find . -name \*.cpp -or -name
\*.h -type f`

[fs, 2014-03-05 11:31:14]

Looks good to me - as straight-forward as advertised. One (very) minor nit,
which is probably ok to punt to a later CL even.

https://codereview.chromium.org/177703004/diff/1/Source/core/svg/SVGAElement.h
File Source/core/svg/SVGAElement.h (right):

https://codereview.chromium.org/177703004/diff/1/Source/core/svg/SVGAElement....
Source/core/svg/SVGAElement.h:58: // This declaration used to define a
non-virtual "String& target() const" method, that clashes with "virtual String
Element::target() const".
Nit: Maybe unindent this comment too? Or maybe just remove it since it seems to
be mostly related to an (older) incarnation of the macros.

[haraken, 2014-03-05 14:08:24]

LGTM if you remove unnecessary empty lines.

https://codereview.chromium.org/177703004/diff/1/Source/core/svg/SVGAElement.cpp
File Source/core/svg/SVGAElement.cpp (right):

https://codereview.chromium.org/177703004/diff/1/Source/core/svg/SVGAElement....
Source/core/svg/SVGAElement.cpp:59: 

Nit: Unnecessary empty lines.

https://codereview.chromium.org/177703004/diff/1/Source/core/svg/SVGAltGlyphE...
File Source/core/svg/SVGAltGlyphElement.cpp (right):

https://codereview.chromium.org/177703004/diff/1/Source/core/svg/SVGAltGlyphE...
Source/core/svg/SVGAltGlyphElement.cpp:40: 

Ditto.

https://codereview.chromium.org/177703004/diff/1/Source/core/svg/SVGAltGlyphE...
File Source/core/svg/SVGAltGlyphElement.h (right):

https://codereview.chromium.org/177703004/diff/1/Source/core/svg/SVGAltGlyphE...
Source/core/svg/SVGAltGlyphElement.h:52: 

Ditto.

https://codereview.chromium.org/177703004/diff/1/Source/core/svg/SVGAnimation...
File Source/core/svg/SVGAnimationElement.h (right):

https://codereview.chromium.org/177703004/diff/1/Source/core/svg/SVGAnimation...
Source/core/svg/SVGAnimationElement.h:227: 

Ditto. The same comment for other places in this CL.

[kouhei (in TOK), 2014-03-06 03:46:04]

https://codereview.chromium.org/177703004/diff/1/Source/core/svg/SVGAElement.cpp
File Source/core/svg/SVGAElement.cpp (right):

https://codereview.chromium.org/177703004/diff/1/Source/core/svg/SVGAElement....
Source/core/svg/SVGAElement.cpp:59: 
On 2014/03/05 14:08:24, haraken wrote:
> 
> Nit: Unnecessary empty lines.

Done.

https://codereview.chromium.org/177703004/diff/1/Source/core/svg/SVGAElement.h
File Source/core/svg/SVGAElement.h (right):

https://codereview.chromium.org/177703004/diff/1/Source/core/svg/SVGAElement....
Source/core/svg/SVGAElement.h:58: // This declaration used to define a
non-virtual "String& target() const" method, that clashes with "virtual String
Element::target() const".
On 2014/03/05 11:31:15, fs wrote:
> Nit: Maybe unindent this comment too? Or maybe just remove it since it seems
to
> be mostly related to an (older) incarnation of the macros.
Removed.

https://codereview.chromium.org/177703004/diff/1/Source/core/svg/SVGAltGlyphE...
File Source/core/svg/SVGAltGlyphElement.cpp (right):

https://codereview.chromium.org/177703004/diff/1/Source/core/svg/SVGAltGlyphE...
Source/core/svg/SVGAltGlyphElement.cpp:40: 
On 2014/03/05 14:08:24, haraken wrote:
> 
> Ditto.

Done.

https://codereview.chromium.org/177703004/diff/1/Source/core/svg/SVGAltGlyphE...
File Source/core/svg/SVGAltGlyphElement.h (right):

https://codereview.chromium.org/177703004/diff/1/Source/core/svg/SVGAltGlyphE...
Source/core/svg/SVGAltGlyphElement.h:52: 
On 2014/03/05 14:08:24, haraken wrote:
> 
> Ditto.

Done.

https://codereview.chromium.org/177703004/diff/1/Source/core/svg/SVGAnimation...
File Source/core/svg/SVGAnimationElement.h (right):

https://codereview.chromium.org/177703004/diff/1/Source/core/svg/SVGAnimation...
Source/core/svg/SVGAnimationElement.h:227: 
On 2014/03/05 14:08:24, haraken wrote:
> 
> Ditto. The same comment for other places in this CL.

Done.

[kouhei (in TOK), 2014-03-06 08:26:18]

The CQ bit was checked by kouhei@chromium.org

[commit-bot: I haz the power, 2014-03-06 08:27:11]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kouhei@chromium.org/177703004/20001

[commit-bot: I haz the power, 2014-03-06 09:25:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-06 09:25:29]

Try jobs failed on following builders: linux_blink

[kouhei (in TOK), 2014-03-06 09:30:04]

The CQ bit was checked by kouhei@chromium.org

[commit-bot: I haz the power, 2014-03-06 09:30:18]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kouhei@chromium.org/177703004/20001

[commit-bot: I haz the power, 2014-03-06 09:38:37]

Change committed as 168613