Source/core/svg/SVGAElement.h - Issue 177703004: [SVG] Remove SVGAnimatedPropertyMacros.h

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: Source/core/svg/SVGAElement.h

Issue 177703004: [SVG] Remove SVGAnimatedPropertyMacros.h (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « no previous file | Source/core/svg/SVGAElement.cpp » ('j') | Source/core/svg/SVGAElement.cpp » ('J')

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 2004, 2005, 2008 Nikolas Zimmermann <zimmermann@kde.org>	2 * Copyright (C) 2004, 2005, 2008 Nikolas Zimmermann <zimmermann@kde.org>

3 * Copyright (C) 2004, 2005 Rob Buis <buis@kde.org>	3 * Copyright (C) 2004, 2005 Rob Buis <buis@kde.org>

4 * Copyright (C) 2007 Eric Seidel <eric@webkit.org>	4 * Copyright (C) 2007 Eric Seidel <eric@webkit.org>

5 *	5 *

6 * This library is free software; you can redistribute it and/or	6 * This library is free software; you can redistribute it and/or

7 * modify it under the terms of the GNU Library General Public	7 * modify it under the terms of the GNU Library General Public

8 * License as published by the Free Software Foundation; either	8 * License as published by the Free Software Foundation; either

9 * version 2 of the License, or (at your option) any later version.	9 * version 2 of the License, or (at your option) any later version.

10 *	10 *

(...skipping 37 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
48 virtual void defaultEventHandler(Event*) OVERRIDE;	48 virtual void defaultEventHandler(Event*) OVERRIDE;

49	49

50 virtual bool supportsFocus() const OVERRIDE;	50 virtual bool supportsFocus() const OVERRIDE;

51 virtual bool isMouseFocusable() const OVERRIDE;	51 virtual bool isMouseFocusable() const OVERRIDE;

52 virtual bool isKeyboardFocusable() const OVERRIDE;	52 virtual bool isKeyboardFocusable() const OVERRIDE;

53 virtual bool isURLAttribute(const Attribute&) const OVERRIDE;	53 virtual bool isURLAttribute(const Attribute&) const OVERRIDE;

54	54

55 virtual bool willRespondToMouseClickEvents() OVERRIDE;	55 virtual bool willRespondToMouseClickEvents() OVERRIDE;

56	56

57 RefPtr<SVGAnimatedString> m_svgTarget;	57 RefPtr<SVGAnimatedString> m_svgTarget;

58 BEGIN_DECLARE_ANIMATED_PROPERTIES(SVGAElement)

59 // This declaration used to define a non-virtual "String& target() const " method, that clashes with "virtual String Element::target() const".	58 // This declaration used to define a non-virtual "String& target() const " method, that clashes with "virtual String Element::target() const".
	fs 2014/03/05 11:31:15 Nit: Maybe unindent this comment too? Or maybe jus Nit: Maybe unindent this comment too? Or maybe just remove it since it seems to be mostly related to an (older) incarnation of the macros. kouhei (in TOK) 2014/03/06 03:46:05 Removed. Show quoted text On 2014/03/05 11:31:15, fs wrote: > Nit: Maybe unindent this comment too? Or maybe just remove it since it seems to > be mostly related to an (older) incarnation of the macros. Removed.
60 // That's why it has been renamed to "svgTarget", the CodeGenerators tak e care of calling svgTargetAnimated() instead of targetAnimated(), see CodeGener ator.pm.	59 // That's why it has been renamed to "svgTarget", the CodeGenerators tak e care of calling svgTargetAnimated() instead of targetAnimated(), see CodeGener ator.pm.

61 END_DECLARE_ANIMATED_PROPERTIES

62 };	60 };

63	61

64 } // namespace WebCore	62 } // namespace WebCore

65	63

66 #endif // SVGAElement_h	64 #endif // SVGAElement_h

OLD	NEW