Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Unified Diff: chrome/common/metrics/proto/system_profile.proto

Issue 17770005: Include CPU information in UMA system profile. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/metrics/metrics_log_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/metrics/proto/system_profile.proto
diff --git a/chrome/common/metrics/proto/system_profile.proto b/chrome/common/metrics/proto/system_profile.proto
index d46e58ebe24966da44f3a0d393acb491ab250c93..d8eb1af31c95bf0acad4c189e99d3562b492fe19 100644
--- a/chrome/common/metrics/proto/system_profile.proto
+++ b/chrome/common/metrics/proto/system_profile.proto
@@ -78,7 +78,7 @@ message SystemProfileProto {
}
optional OS os = 5;
- // Next tag for Hardware: 13
+ // Next tag for Hardware: 14
// Information on the user's hardware.
message Hardware {
// The CPU architecture (x86, PowerPC, x86_64, ...)
@@ -116,6 +116,18 @@ message SystemProfileProto {
optional float max_dpi_x = 9;
optional float max_dpi_y = 10;
+ // Information on the CPU obtained by CPUID.
+ message CPU {
+ optional string vendor_name = 1;
+ optional uint32 stepping = 2;
+ optional uint32 model = 3;
+ optional uint32 family = 4;
+ optional uint32 type = 5;
+ optional uint32 extended_model = 6;
+ optional uint32 extended_family = 7;
Ilya Sherman 2013/06/26 00:43:01 Please document each of these fields.
+ }
+ optional CPU cpu = 13;
+
// Information on the GPU
message Graphics {
// The GPU manufacturer's vendor id.
« no previous file with comments | « chrome/browser/metrics/metrics_log_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698