Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Unified Diff: chrome/browser/metrics/metrics_log_unittest.cc

Issue 17770005: Include CPU information in UMA system profile. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/metrics/metrics_log_unittest.cc
diff --git a/chrome/browser/metrics/metrics_log_unittest.cc b/chrome/browser/metrics/metrics_log_unittest.cc
index b78c0d76b746ec79bc585a84ea2eb3426e177aa1..06ffbd7e58d9c5e9f252927d971876bc9430bb96 100644
--- a/chrome/browser/metrics/metrics_log_unittest.cc
+++ b/chrome/browser/metrics/metrics_log_unittest.cc
@@ -152,6 +152,15 @@ class MetricsLogTest : public testing::Test {
EXPECT_EQ(kScreenScaleFactor, hardware.primary_screen_scale_factor());
EXPECT_EQ(kScreenCount, hardware.screen_count());
+ ASSERT_TRUE(hardware.has_cpu());
+ EXPECT_TRUE(hardware.cpu().has_vendor_name());
+ EXPECT_TRUE(hardware.cpu().has_stepping());
+ EXPECT_TRUE(hardware.cpu().has_model());
+ EXPECT_TRUE(hardware.cpu().has_family());
+ EXPECT_TRUE(hardware.cpu().has_type());
+ EXPECT_TRUE(hardware.cpu().has_extended_model());
+ EXPECT_TRUE(hardware.cpu().has_extended_family());
+
// TODO(isherman): Verify other data written into the protobuf as a result
// of this call.
}

Powered by Google App Engine
This is Rietveld 408576698