Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(457)

Issue 1776883004: Change the title of the password bubble for Android credentials. (Closed)

Created:
4 years, 9 months ago by vasilii
Modified:
4 years, 9 months ago
Reviewers:
engedy
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2661
Target Ref:
refs/pending/branch-heads/2661
Project:
chromium
Visibility:
Public.

Description

Change the title of the password bubble for Android credentials. The bubble should show Android human readable package name instead of the long hash. This is a quick fix to be merged back to M50. BUG=592382 TBR=engedy@chromium.org NOTRY=true NOPRESUBMIT=true Review URL: https://codereview.chromium.org/1771363002 Cr-Commit-Position: refs/heads/master@{#379838} (cherry picked from commit 6e0f50a8d8f4dbb34c38cdd85c889b7843ddc83b)

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -3 lines) Patch
M chrome/browser/ui/passwords/manage_passwords_view_utils.cc View 2 chunks +16 lines, -2 lines 0 comments Download
M chrome/browser/ui/passwords/manage_passwords_view_utils_unittest.cc View 1 chunk +12 lines, -1 line 0 comments Download

Messages

Total messages: 12 (8 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1776883004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1776883004/1
4 years, 9 months ago (2016-03-09 18:35:42 UTC) #4
commit-bot: I haz the power
CLs for remote refs other than refs/pending/heads/master must contain NOTRY=true and NOPRESUBMIT=true in order for ...
4 years, 9 months ago (2016-03-09 18:35:44 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1776883004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1776883004/1
4 years, 9 months ago (2016-03-09 18:41:30 UTC) #10
commit-bot: I haz the power
4 years, 9 months ago (2016-03-09 18:42:48 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1)

Powered by Google App Engine
This is Rietveld 408576698