Change the title of the password bubble for Android credentials.

Change the title of the password bubble for Android credentials.

The bubble should show Android human readable package name instead of the long hash. This is a quick fix to be merged back to M50.

BUG=592382
Committed: https://crrev.com/6e0f50a8d8f4dbb34c38cdd85c889b7843ddc83b
Cr-Commit-Position: refs/heads/master@{#379838}

[vasilii, 2016-03-08 14:47:12]

Description was changed from

==========
Change the title of the password bubble for Android credentials.

BUG=592382
==========

to

==========
Change the title of the password bubble for Android credentials.

The bubble should show Android human readable package name instead of the long
hash. This is a quick fix to be merged back to M50.

BUG=592382
==========

[vasilii, 2016-03-08 14:47:12]

vasilii@chromium.org changed reviewers:
+ engedy@chromium.org

[vasilii, 2016-03-08 14:47:31]

Hi Balazs,

please review.

[engedy, 2016-03-08 15:24:09]

LGTM % one comment. Thanks a lot for creating this fix, and also for spending
time on figuring out why things broke in the first place.

https://codereview.chromium.org/1771363002/diff/1/chrome/browser/ui/passwords...
File chrome/browser/ui/passwords/manage_passwords_view_utils_unittest.cc
(right):

https://codereview.chromium.org/1771363002/diff/1/chrome/browser/ui/passwords...
chrome/browser/ui/passwords/manage_passwords_view_utils_unittest.cc:88: false,
PasswordTittleType::SAVE_PASSWORD, "android://com.example.android",
Does it make any difference if this is SAVE_PASSWORD or UPDATE_PASSWORD?

[vasilii, 2016-03-08 15:32:37]

https://codereview.chromium.org/1771363002/diff/1/chrome/browser/ui/passwords...
File chrome/browser/ui/passwords/manage_passwords_view_utils_unittest.cc
(right):

https://codereview.chromium.org/1771363002/diff/1/chrome/browser/ui/passwords...
chrome/browser/ui/passwords/manage_passwords_view_utils_unittest.cc:88: false,
PasswordTittleType::SAVE_PASSWORD, "android://com.example.android",
On 2016/03/08 15:24:09, engedy wrote:
> Does it make any difference if this is SAVE_PASSWORD or UPDATE_PASSWORD?

SAVE_PASSWORD makes no sense for android credentials on desktop. However, we
don't have a correct string for the update bubble in case of different origins
(we reuse the save string). This is something Vadym should fix but not for M50.
If I change the type to UPDATE_PASSWORD then the test will be looking for
"update" in the title and fail.

[vasilii, 2016-03-08 15:35:16]

The CQ bit was checked by vasilii@chromium.org

[commit-bot: I haz the power, 2016-03-08 15:35:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1771363002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1771363002/1

[engedy, 2016-03-08 15:37:52]

https://codereview.chromium.org/1771363002/diff/1/chrome/browser/ui/passwords...
File chrome/browser/ui/passwords/manage_passwords_view_utils_unittest.cc
(right):

https://codereview.chromium.org/1771363002/diff/1/chrome/browser/ui/passwords...
chrome/browser/ui/passwords/manage_passwords_view_utils_unittest.cc:88: false,
PasswordTittleType::SAVE_PASSWORD, "android://com.example.android",
On 2016/03/08 15:32:37, vasilii wrote:
> On 2016/03/08 15:24:09, engedy wrote:
> > Does it make any difference if this is SAVE_PASSWORD or UPDATE_PASSWORD?
> 
> SAVE_PASSWORD makes no sense for android credentials on desktop. However, we
> don't have a correct string for the update bubble in case of different origins
> (we reuse the save string). This is something Vadym should fix but not for
M50.
> If I change the type to UPDATE_PASSWORD then the test will be looking for
> "update" in the title and fail.

Ah, OK.  Have you documented this issue somewhere?

[vasilii, 2016-03-08 15:46:50]

On 2016/03/08 15:37:52, engedy wrote:
>
https://codereview.chromium.org/1771363002/diff/1/chrome/browser/ui/passwords...
> File chrome/browser/ui/passwords/manage_passwords_view_utils_unittest.cc
> (right):
> 
>
https://codereview.chromium.org/1771363002/diff/1/chrome/browser/ui/passwords...
> chrome/browser/ui/passwords/manage_passwords_view_utils_unittest.cc:88: false,
> PasswordTittleType::SAVE_PASSWORD, "android://com.example.android",
> On 2016/03/08 15:32:37, vasilii wrote:
> > On 2016/03/08 15:24:09, engedy wrote:
> > > Does it make any difference if this is SAVE_PASSWORD or UPDATE_PASSWORD?
> > 
> > SAVE_PASSWORD makes no sense for android credentials on desktop. However, we
> > don't have a correct string for the update bubble in case of different
origins
> > (we reuse the save string). This is something Vadym should fix but not for
> M50.
> > If I change the type to UPDATE_PASSWORD then the test will be looking for
> > "update" in the title and fail.
> 
> Ah, OK.  Have you documented this issue somewhere?

I submitted http://crbug.com/593034

[commit-bot: I haz the power, 2016-03-08 16:22:53]

Description was changed from

==========
Change the title of the password bubble for Android credentials.

The bubble should show Android human readable package name instead of the long
hash. This is a quick fix to be merged back to M50.

BUG=592382
==========

to

==========
Change the title of the password bubble for Android credentials.

The bubble should show Android human readable package name instead of the long
hash. This is a quick fix to be merged back to M50.

BUG=592382
==========

[commit-bot: I haz the power, 2016-03-08 16:22:54]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-03-08 16:24:27]

Description was changed from

==========
Change the title of the password bubble for Android credentials.

The bubble should show Android human readable package name instead of the long
hash. This is a quick fix to be merged back to M50.

BUG=592382
==========

to

==========
Change the title of the password bubble for Android credentials.

The bubble should show Android human readable package name instead of the long
hash. This is a quick fix to be merged back to M50.

BUG=592382

Committed: https://crrev.com/6e0f50a8d8f4dbb34c38cdd85c889b7843ddc83b
Cr-Commit-Position: refs/heads/master@{#379838}
==========

[commit-bot: I haz the power, 2016-03-08 16:24:28]

Patchset 1 (id:??) landed as
https://crrev.com/6e0f50a8d8f4dbb34c38cdd85c889b7843ddc83b
Cr-Commit-Position: refs/heads/master@{#379838}