Convert the flaky SysCommand widget tests into interactive ui tests.

Convert the flaky SysCommand widget tests into interactive ui tests.

It looks like these tests are flaky due to window messages not firing as expected. Hopefully
with these tests being converted to interactive ui tests we should not have flakiness due to activation
and related problems.

Tests being converted are as below:-
1. DestroyInSysCommandNCLButtonDownOnCaption
2. SysCommandMoveOnNCLButtonDownOnCaptionAndMoveTest

BUG=592742
Committed: https://crrev.com/da9b02d4f7b5c2ad53e6e0573edaf8f48c892ba3
Cr-Commit-Position: refs/heads/master@{#379991}

[ananta, 2016-03-08 20:06:27]

ananta@chromium.org changed reviewers:
+ sky@chromium.org

[sky, 2016-03-08 22:51:34]

LGTM - I wonder if you're converting to a flaky interactive ui test. We'll
see...

[ananta, 2016-03-09 00:07:52]

The CQ bit was checked by ananta@chromium.org

[commit-bot: I haz the power, 2016-03-09 00:08:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1776763002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1776763002/1

[commit-bot: I haz the power, 2016-03-09 00:27:00]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-03-09 00:28:02]

Description was changed from

==========
Convert the flaky SysCommand widget tests into interactive ui tests.

It looks like these tests are flaky due to window messages not firing as
expected. Hopefully
with these tests being converted to interactive ui tests we should not have
flakiness due to activation
and related problems.

Tests being converted are as below:-
1. DestroyInSysCommandNCLButtonDownOnCaption
2. SysCommandMoveOnNCLButtonDownOnCaptionAndMoveTest

BUG=592742
==========

to

==========
Convert the flaky SysCommand widget tests into interactive ui tests.

It looks like these tests are flaky due to window messages not firing as
expected. Hopefully
with these tests being converted to interactive ui tests we should not have
flakiness due to activation
and related problems.

Tests being converted are as below:-
1. DestroyInSysCommandNCLButtonDownOnCaption
2. SysCommandMoveOnNCLButtonDownOnCaptionAndMoveTest

BUG=592742

Committed: https://crrev.com/da9b02d4f7b5c2ad53e6e0573edaf8f48c892ba3
Cr-Commit-Position: refs/heads/master@{#379991}
==========

[commit-bot: I haz the power, 2016-03-09 00:28:03]

Patchset 1 (id:??) landed as
https://crrev.com/da9b02d4f7b5c2ad53e6e0573edaf8f48c892ba3
Cr-Commit-Position: refs/heads/master@{#379991}

[tsergeant, 2016-03-09 03:21:33]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1774413002/ by tsergeant@chromium.org.

The reason for reverting is: The test
WidgetTestInteractive.SysCommandMoveOnNCLButtonDownOnCaptionAndMoveTest is
failing in interactive_ui_tests on Windows-7-SP1. See:

https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%2....

[sky, 2016-03-09 03:59:38]

I knew it!

On Tue, Mar 8, 2016 at 7:21 PM,  <tsergeant@chromium.org> wrote:
> A revert of this CL (patchset #1 id:1) has been created in
> https://codereview.chromium.org/1774413002/ by tsergeant@chromium.org.
>
> The reason for reverting is: The test
> WidgetTestInteractive.SysCommandMoveOnNCLButtonDownOnCaptionAndMoveTest is
> failing in interactive_ui_tests on Windows-7-SP1. See:
>
>
https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%2....
>
> https://codereview.chromium.org/1776763002/

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.