Convert the flaky SysCommand widget tests into interactive ui tests.

ui/views/widget/widget_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <algorithm>
 #include <set>
 
 #include "base/bind.h"
 #include "base/macros.h"
 #include "base/memory/scoped_ptr.h"
@@ skipping 3170 matching lines @@
       reinterpret_cast<ui::WindowEventTarget*>(ui::ViewProp::GetValue(
           widget.GetNativeWindow()->GetHost()->GetAcceleratedWidget(),
           ui::WindowEventTarget::kWin32InputEventTarget));
   EXPECT_NE(nullptr, target);
   bool handled = false;
   target->HandleKeyboardMessage(WM_CHAR, 0, 0, &handled);
   target->HandleKeyboardMessage(WM_SYSCHAR, 0, 0, &handled);
   target->HandleKeyboardMessage(WM_SYSDEADCHAR, 0, 0, &handled);
   widget.CloseNow();
 }
-
-// Provides functionality to subclass a window and keep track of messages
-// received.
-class SubclassWindowHelper {
- public:
-  explicit SubclassWindowHelper(HWND window)
-      : window_(window),
-        message_to_destroy_on_(0) {
-    EXPECT_EQ(instance_, nullptr);
-    instance_ = this;
-    EXPECT_TRUE(Subclass());
-  }
-
-  ~SubclassWindowHelper() {
-    Unsubclass();
-    instance_ = nullptr;
-  }
-
-  // Returns true if the |message| passed in was received.
-  bool received_message(unsigned int message) {
-    return (messages_.find(message) != messages_.end());
-  }
-
-  void Clear() {
-    messages_.clear();
-  }
-
-  void set_message_to_destroy_on(unsigned int message) {
-    message_to_destroy_on_ = message;
-  }
-
- private:
-  bool Subclass() {
-    old_proc_ = reinterpret_cast<WNDPROC>(
-        ::SetWindowLongPtr(window_,
-                           GWLP_WNDPROC,
-                           reinterpret_cast<LONG_PTR>(WndProc)));
-    return old_proc_ != nullptr;
-  }
-
-  void Unsubclass() {
-    ::SetWindowLongPtr(window_,
-                       GWLP_WNDPROC,
-                       reinterpret_cast<LONG_PTR>(old_proc_));
-  }
-
-  static LRESULT CALLBACK WndProc(HWND window,
-                                  unsigned int message,
-                                  WPARAM w_param,
-                                  LPARAM l_param) {
-    EXPECT_NE(instance_, nullptr);
-    EXPECT_EQ(window, instance_->window_);
-
-    // Keep track of messags received for this window.
-    instance_->messages_.insert(message);
-
-    LRESULT ret = ::CallWindowProc(instance_->old_proc_, window, message,
-                                   w_param, l_param);
-    if (message == instance_->message_to_destroy_on_) {
-      instance_->Unsubclass();
-      ::DestroyWindow(window);
-    }
-    return ret;
-  }
-
-  WNDPROC old_proc_;
-  HWND window_;
-  static SubclassWindowHelper* instance_;
-  std::set<unsigned int> messages_;
-  unsigned int message_to_destroy_on_;
-
-  DISALLOW_COPY_AND_ASSIGN(SubclassWindowHelper);
-};
-
-SubclassWindowHelper* SubclassWindowHelper::instance_ = nullptr;
-
-// This test validates whether the WM_SYSCOMMAND message for SC_MOVE is
-// received when we post a WM_NCLBUTTONDOWN message for the caption in the
-// following scenarios:-
-// 1. Posting a WM_NCMOUSEMOVE message for a different location.
-// 2. Posting a WM_NCMOUSEMOVE message with a different hittest code.
-// 3. Posting a WM_MOUSEMOVE message.
-// Disabled because of flaky timeouts: http://crbug.com/592742
-TEST_F(WidgetTest, DISABLED_SysCommandMoveOnNCLButtonDownOnCaptionAndMoveTest) {
-  Widget widget;
-  Widget::InitParams params =
-      CreateParams(Widget::InitParams::TYPE_WINDOW);
-  params.native_widget =
-      CreatePlatformDesktopNativeWidgetImpl(params, &widget, nullptr);
-  params.ownership = Widget::InitParams::WIDGET_OWNS_NATIVE_WIDGET;
-  widget.Init(params);
-  widget.SetBounds(gfx::Rect(0, 0, 200, 200));
-  widget.Show();
-  ::SetCursorPos(500, 500);
-
-  HWND window = widget.GetNativeWindow()->GetHost()->GetAcceleratedWidget();
-
-  SubclassWindowHelper subclass_helper(window);
-
-  // Posting just a WM_NCLBUTTONDOWN message should not result in a
-  // WM_SYSCOMMAND
-  ::PostMessage(window, WM_NCLBUTTONDOWN, HTCAPTION, MAKELPARAM(100, 100));
-  RunPendingMessages();
-  EXPECT_TRUE(subclass_helper.received_message(WM_NCLBUTTONDOWN));
-  EXPECT_FALSE(subclass_helper.received_message(WM_SYSCOMMAND));
-
-  subclass_helper.Clear();
-  // Posting a WM_NCLBUTTONDOWN message followed by a WM_NCMOUSEMOVE at the
-  // same location should not result in a WM_SYSCOMMAND message.
-  ::PostMessage(window, WM_NCLBUTTONDOWN, HTCAPTION, MAKELPARAM(100, 100));
-  ::PostMessage(window, WM_NCMOUSEMOVE, HTCAPTION, MAKELPARAM(100, 100));
-  RunPendingMessages();
-
-  EXPECT_TRUE(subclass_helper.received_message(WM_NCLBUTTONDOWN));
-  EXPECT_TRUE(subclass_helper.received_message(WM_NCMOUSEMOVE));
-  EXPECT_FALSE(subclass_helper.received_message(WM_SYSCOMMAND));
-
-  subclass_helper.Clear();
- // Posting a WM_NCLBUTTONDOWN message followed by a WM_NCMOUSEMOVE at a
-  // different location should result in a WM_SYSCOMMAND message.
-  ::PostMessage(window, WM_NCLBUTTONDOWN, HTCAPTION, MAKELPARAM(100, 100));
-  ::PostMessage(window, WM_NCMOUSEMOVE, HTCAPTION, MAKELPARAM(110, 110));
-  RunPendingMessages();
-
-  EXPECT_TRUE(subclass_helper.received_message(WM_NCLBUTTONDOWN));
-  EXPECT_TRUE(subclass_helper.received_message(WM_NCMOUSEMOVE));
-  EXPECT_TRUE(subclass_helper.received_message(WM_SYSCOMMAND));
-
-  subclass_helper.Clear();
- // Posting a WM_NCLBUTTONDOWN message followed by a WM_NCMOUSEMOVE at a
-  // different location with a different hittest code should result in a
-  // WM_SYSCOMMAND message.
-  ::PostMessage(window, WM_NCLBUTTONDOWN, HTCAPTION, MAKELPARAM(100, 100));
-  ::PostMessage(window, WM_NCMOUSEMOVE, HTTOP, MAKELPARAM(110, 102));
-  RunPendingMessages();
-
-  EXPECT_TRUE(subclass_helper.received_message(WM_NCLBUTTONDOWN));
-  EXPECT_TRUE(subclass_helper.received_message(WM_NCMOUSEMOVE));
-  EXPECT_TRUE(subclass_helper.received_message(WM_SYSCOMMAND));
-
-  subclass_helper.Clear();
-  // Posting a WM_NCLBUTTONDOWN message followed by a WM_MOUSEMOVE should
-  // result in a WM_SYSCOMMAND message.
-  ::PostMessage(window, WM_NCLBUTTONDOWN, HTCAPTION, MAKELPARAM(100, 100));
-  ::PostMessage(window, WM_MOUSEMOVE, HTCLIENT, MAKELPARAM(110, 110));
-  RunPendingMessages();
-
-  EXPECT_TRUE(subclass_helper.received_message(WM_NCLBUTTONDOWN));
-  EXPECT_TRUE(subclass_helper.received_message(WM_MOUSEMOVE));
-  EXPECT_TRUE(subclass_helper.received_message(WM_SYSCOMMAND));
-
-  widget.CloseNow();
-}
-
-// This test validates that destroying the window in the context of the
-// WM_SYSCOMMAND message with SC_MOVE does not crash.
-// Disabled because of flaky timeouts: http://crbug.com/592742
-TEST_F(WidgetTest, DISABLED_DestroyInSysCommandNCLButtonDownOnCaption) {
-  Widget widget;
-  Widget::InitParams params =
-      CreateParams(Widget::InitParams::TYPE_WINDOW);
-  params.native_widget =
-      CreatePlatformDesktopNativeWidgetImpl(params, &widget, nullptr);
-  params.ownership = Widget::InitParams::WIDGET_OWNS_NATIVE_WIDGET;
-  widget.Init(params);
-  widget.SetBounds(gfx::Rect(0, 0, 200, 200));
-  widget.Show();
-  ::SetCursorPos(500, 500);
-
-  HWND window = widget.GetNativeWindow()->GetHost()->GetAcceleratedWidget();
-
-  SubclassWindowHelper subclass_helper(window);
-
-  // Destroying the window in the context of the WM_SYSCOMMAND message
-  // should not crash.
-  subclass_helper.set_message_to_destroy_on(WM_SYSCOMMAND);
-
-  ::PostMessage(window, WM_NCLBUTTONDOWN, HTCAPTION, MAKELPARAM(100, 100));
-  ::PostMessage(window, WM_NCMOUSEMOVE, HTCAPTION, MAKELPARAM(110, 110));
-  RunPendingMessages();
-
-  EXPECT_TRUE(subclass_helper.received_message(WM_NCLBUTTONDOWN));
-  EXPECT_TRUE(subclass_helper.received_message(WM_SYSCOMMAND));
-
-  widget.CloseNow();
-}
-
 #endif
 
 // Test that SetAlwaysOnTop and IsAlwaysOnTop are consistent.
 TEST_F(WidgetTest, AlwaysOnTop) {
   WidgetAutoclosePtr widget(CreateTopLevelNativeWidget());
   EXPECT_FALSE(widget->IsAlwaysOnTop());
   widget->SetAlwaysOnTop(true);
   EXPECT_TRUE(widget->IsAlwaysOnTop());
   widget->SetAlwaysOnTop(false);
   EXPECT_FALSE(widget->IsAlwaysOnTop());
@@ skipping 109 matching lines @@
   // Moving the child to a different widget should call the removals observer.
   WidgetAutoclosePtr widget2(CreateTopLevelPlatformWidget());
   widget2->client_view()->AddChildView(child);
   EXPECT_TRUE(removals_observer.DidRemoveView(child));
 
   widget->RemoveRemovalsObserver(&removals_observer);
 }
 
 }  // namespace test
 }  // namespace views