Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(834)

Side by Side Diff: ui/events/keycodes/platform_key_map_win.h

Issue 1776673007: [Windows] Produce correct DomKey for NumPad when combined with Shift/NumLock (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2016 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef UI_EVENTS_KEYCODES_PLATFORM_KEY_MAP_WIN_H_ 5 #ifndef UI_EVENTS_KEYCODES_PLATFORM_KEY_MAP_WIN_H_
6 #define UI_EVENTS_KEYCODES_PLATFORM_KEY_MAP_WIN_H_ 6 #define UI_EVENTS_KEYCODES_PLATFORM_KEY_MAP_WIN_H_
7 7
8 #include <windows.h> 8 #include <windows.h>
9 9
10 #include <unordered_map> 10 #include <unordered_map>
11 11
12 #include "base/hash.h" 12 #include "base/hash.h"
13 #include "ui/events/events_base_export.h" 13 #include "ui/events/events_base_export.h"
14 #include "ui/events/keycodes/dom/dom_key.h" 14 #include "ui/events/keycodes/dom/dom_key.h"
15 #include "ui/events/keycodes/keyboard_codes_win.h" 15 #include "ui/events/keycodes/keyboard_codes_win.h"
16 16
17 namespace ui { 17 namespace ui {
18 18
19 enum class DomCode; 19 enum class DomCode;
20 20
21 class EVENTS_BASE_EXPORT PlatformKeyMap { 21 class EVENTS_BASE_EXPORT PlatformKeyMap {
22 public: 22 public:
23 // Create and load key map table with specified keyboard layout. 23 // Create and load key map table with specified keyboard layout.
24 explicit PlatformKeyMap(HKL layout); 24 explicit PlatformKeyMap(HKL layout);
25 ~PlatformKeyMap(); 25 ~PlatformKeyMap();
26 26
27 // Returns the DomKey 'meaning' of |code| in the context of specified 27 // Returns the DomKey 'meaning' of |code| in the context of specified
28 // |ui_event_flags| and stored keyboard layout. 28 // |ui_event_flags| and stored keyboard layout.
29 // |key_code| will only be used for NumPad.
29 DomKey DomCodeAndFlagsToDomKey(DomCode code, 30 DomKey DomCodeAndFlagsToDomKey(DomCode code,
31 KeyboardCode key_code,
30 int ui_event_flags) const; 32 int ui_event_flags) const;
31 33
32 // Returns the DomKey 'meaning' of |code| in the context of specified 34 // Returns the DomKey 'meaning' of |code| in the context of specified
33 // |ui_event_flags| and the keyboard layout of current thread. 35 // |ui_event_flags| and the keyboard layout of current thread.
34 // Updates a per-thread key map cache whenever the layout changes. 36 // Updates a per-thread key map cache whenever the layout changes.
35 static DomKey DomCodeAndFlagsToDomKeyStatic( 37 // |key_code| will only be used for NumPad.
36 DomCode code, 38 static DomKey DomCodeAndFlagsToDomKeyStatic(DomCode code,
37 int ui_event_flags); 39 KeyboardCode key_code,
40 int ui_event_flags);
chongz 2016/03/10 00:59:10 This interface looks ugly but I don't have a bette
38 41
39 private: 42 private:
40 PlatformKeyMap(); 43 PlatformKeyMap();
41 44
42 // TODO(chongz): Expose this function in response to WM_INPUTLANGCHANGE. 45 // TODO(chongz): Expose this function in response to WM_INPUTLANGCHANGE.
43 void UpdateLayout(HKL layout); 46 void UpdateLayout(HKL layout);
44 47
45 HKL keyboard_layout_ = 0; 48 HKL keyboard_layout_ = 0;
46 49
47 // TODO(chongz): Change type to DomCode when we got a generic pair hash class. 50 // TODO(chongz): Change type to DomCode when we got a generic pair hash class.
48 typedef std::pair<int /*DomCode*/, int /*EventFlags*/> DomCodeEventFlagsPair; 51 typedef std::pair<int /*DomCode*/, int /*EventFlags*/> DomCodeEventFlagsPair;
49 typedef std::unordered_map<DomCodeEventFlagsPair, 52 typedef std::unordered_map<DomCodeEventFlagsPair,
50 DomKey, 53 DomKey,
51 base::IntPairHash<std::pair<int, int>>> 54 base::IntPairHash<std::pair<int, int>>>
52 DomCodeToKeyMap; 55 DomCodeToKeyMap;
53 DomCodeToKeyMap code_to_key_; 56 DomCodeToKeyMap code_to_key_;
54 57
55 DISALLOW_COPY_AND_ASSIGN(PlatformKeyMap); 58 DISALLOW_COPY_AND_ASSIGN(PlatformKeyMap);
56 }; 59 };
57 60
58 } // namespace ui 61 } // namespace ui
59 62
60 #endif // UI_EVENTS_KEYCODES_PLATFORM_KEY_MAP_WIN_H_ 63 #endif // UI_EVENTS_KEYCODES_PLATFORM_KEY_MAP_WIN_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698