MIPS: Fix '[wasm] add rotate opcodes'

MIPS: Fix '[wasm] add rotate opcodes'

Port 9d0cf920bd59389f3ec408fa93aa6277a9cdab9c

Bug Descriptions:
1. We are missing drotr32 instruction
2. Ror Macro should also handle values less than zero or bigger than 31, as WASM instruction kExprI32Rol will generate shifting operands beyond [0 .. 31] range.
3. Same as Dror.
4. drotrv instruction in simulator is incorrect.

BUG=
TEST=cctest/test-run-wasm/Run_WasmInt32Binops,cctest/test-run-wasm/Run_WasmInt64Binops

Committed: https://crrev.com/4ec5a1e368dc10a48c57caebdcf7f991af866b50
Cr-Commit-Position: refs/heads/master@{#34632}

[akos.palfi.imgtec, 2016-03-09 13:04:21]

akos.palfi@imgtec.com changed reviewers:
+ akos.palfi@imgtec.com, balazs.kilvady@imgtec.com

[akos.palfi.imgtec, 2016-03-09 13:04:22]

Nit: remove this line from the description: '[wasm] add rotate opcodes'

https://codereview.chromium.org/1776623002/diff/1/src/mips64/macro-assembler-...
File src/mips64/macro-assembler-mips64.cc (right):

https://codereview.chromium.org/1776623002/diff/1/src/mips64/macro-assembler-...
src/mips64/macro-assembler-mips64.cc:1241: int64_t shift_value = rt.imm64_;
Why don't you use the same approach here that you use at Ror(), it would make
the code more consistent.

-    int64_t shift_value = rt.imm64_;
-    if (shift_value < 0) shift_value += 64;
-    if (shift_value >= 64) shift_value -= 64;
+    int64_t shift_value = rt.imm64_ % 64;
+    if (shift_value < 0) {
+      shift_value += 64;
+    }

[Alan Li, 2016-03-09 13:09:26]

Description was changed from

==========
MIPS: Fix '[wasm] add rotate opcodes'

Port 9d0cf920bd59389f3ec408fa93aa6277a9cdab9c

[wasm] add rotate opcodes

Bug Descriptions:
1. We are missing drotr32 instruction
2. Ror Macro should also handle values less than zero or bigger than 31, as WASM
instruction kExprI32Rol will generate shifting operands beyond [0 .. 31] range.
3. Same as Dror.
4. drotrv instruction in simulator is incorrect.

BUG=
TEST=cctest/test-run-wasm/Run_WasmInt32Binops,cctest/test-run-wasm/Run_WasmInt64Binops
==========

to

==========
MIPS: Fix '[wasm] add rotate opcodes'

Port 9d0cf920bd59389f3ec408fa93aa6277a9cdab9c

Bug Descriptions:
1. We are missing drotr32 instruction
2. Ror Macro should also handle values less than zero or bigger than 31, as WASM
instruction kExprI32Rol will generate shifting operands beyond [0 .. 31] range.
3. Same as Dror.
4. drotrv instruction in simulator is incorrect.

BUG=
TEST=cctest/test-run-wasm/Run_WasmInt32Binops,cctest/test-run-wasm/Run_WasmInt64Binops
==========

[Alan Li, 2016-03-09 13:34:23]

On 2016/03/09 13:04:22, akos.palfi.imgtec wrote:
> Nit: remove this line from the description: '[wasm] add rotate opcodes'

Done.

> 
>
https://codereview.chromium.org/1776623002/diff/1/src/mips64/macro-assembler-...
> File src/mips64/macro-assembler-mips64.cc (right):
> 
>
https://codereview.chromium.org/1776623002/diff/1/src/mips64/macro-assembler-...
> src/mips64/macro-assembler-mips64.cc:1241: int64_t shift_value = rt.imm64_;
> Why don't you use the same approach here that you use at Ror(), it would make
> the code more consistent.
> 
> -    int64_t shift_value = rt.imm64_;
> -    if (shift_value < 0) shift_value += 64;
> -    if (shift_value >= 64) shift_value -= 64;
> +    int64_t shift_value = rt.imm64_ % 64;
> +    if (shift_value < 0) {
> +      shift_value += 64;
> +    }

[Alan Li, 2016-03-09 13:34:35]

https://codereview.chromium.org/1776623002/diff/1/src/mips64/macro-assembler-...
File src/mips64/macro-assembler-mips64.cc (right):

https://codereview.chromium.org/1776623002/diff/1/src/mips64/macro-assembler-...
src/mips64/macro-assembler-mips64.cc:1241: int64_t shift_value = rt.imm64_;
On 2016/03/09 13:04:21, akos.palfi.imgtec wrote:
> Why don't you use the same approach here that you use at Ror(), it would make
> the code more consistent.
> 
> -    int64_t shift_value = rt.imm64_;
> -    if (shift_value < 0) shift_value += 64;
> -    if (shift_value >= 64) shift_value -= 64;
> +    int64_t shift_value = rt.imm64_ % 64;
> +    if (shift_value < 0) {
> +      shift_value += 64;
> +    }

Done.

[akos.palfi.imgtec, 2016-03-09 14:13:01]

LGTM

[Alan Li, 2016-03-09 17:09:03]

The CQ bit was checked by alan.li@imgtec.com

[commit-bot: I haz the power, 2016-03-09 17:09:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1776623002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1776623002/20001

[commit-bot: I haz the power, 2016-03-09 17:32:30]

Description was changed from

==========
MIPS: Fix '[wasm] add rotate opcodes'

Port 9d0cf920bd59389f3ec408fa93aa6277a9cdab9c

Bug Descriptions:
1. We are missing drotr32 instruction
2. Ror Macro should also handle values less than zero or bigger than 31, as WASM
instruction kExprI32Rol will generate shifting operands beyond [0 .. 31] range.
3. Same as Dror.
4. drotrv instruction in simulator is incorrect.

BUG=
TEST=cctest/test-run-wasm/Run_WasmInt32Binops,cctest/test-run-wasm/Run_WasmInt64Binops
==========

to

==========
MIPS: Fix '[wasm] add rotate opcodes'

Port 9d0cf920bd59389f3ec408fa93aa6277a9cdab9c

Bug Descriptions:
1. We are missing drotr32 instruction
2. Ror Macro should also handle values less than zero or bigger than 31, as WASM
instruction kExprI32Rol will generate shifting operands beyond [0 .. 31] range.
3. Same as Dror.
4. drotrv instruction in simulator is incorrect.

BUG=
TEST=cctest/test-run-wasm/Run_WasmInt32Binops,cctest/test-run-wasm/Run_WasmInt64Binops
==========

[commit-bot: I haz the power, 2016-03-09 17:32:31]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-03-09 17:33:01]

Description was changed from

==========
MIPS: Fix '[wasm] add rotate opcodes'

Port 9d0cf920bd59389f3ec408fa93aa6277a9cdab9c

Bug Descriptions:
1. We are missing drotr32 instruction
2. Ror Macro should also handle values less than zero or bigger than 31, as WASM
instruction kExprI32Rol will generate shifting operands beyond [0 .. 31] range.
3. Same as Dror.
4. drotrv instruction in simulator is incorrect.

BUG=
TEST=cctest/test-run-wasm/Run_WasmInt32Binops,cctest/test-run-wasm/Run_WasmInt64Binops
==========

to

==========
MIPS: Fix '[wasm] add rotate opcodes'

Port 9d0cf920bd59389f3ec408fa93aa6277a9cdab9c

Bug Descriptions:
1. We are missing drotr32 instruction
2. Ror Macro should also handle values less than zero or bigger than 31, as WASM
instruction kExprI32Rol will generate shifting operands beyond [0 .. 31] range.
3. Same as Dror.
4. drotrv instruction in simulator is incorrect.

BUG=
TEST=cctest/test-run-wasm/Run_WasmInt32Binops,cctest/test-run-wasm/Run_WasmInt64Binops

Committed: https://crrev.com/4ec5a1e368dc10a48c57caebdcf7f991af866b50
Cr-Commit-Position: refs/heads/master@{#34632}
==========

[commit-bot: I haz the power, 2016-03-09 17:33:02]

Patchset 2 (id:??) landed as
https://crrev.com/4ec5a1e368dc10a48c57caebdcf7f991af866b50
Cr-Commit-Position: refs/heads/master@{#34632}