DevTools: Get rid of redundant default selection during inspectElement

DevTools: Get rid of redundant default selection during inspectElement

BUG=

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168503

[pfeldman, 2014-02-25 16:28:12]

https://codereview.chromium.org/177653004/diff/1/Source/devtools/front_end/in...
File Source/devtools/front_end/inspector.js (right):

https://codereview.chromium.org/177653004/diff/1/Source/devtools/front_end/in...
Source/devtools/front_end/inspector.js:843:
WebInspector.panel("elements").revealAndSelectNode(nodeId);
Do this using revealer instead.

[pfeldman, 2014-02-28 09:55:36]

lgtm

[sergeyv, 2014-02-28 11:57:25]

The CQ bit was checked by sergeyv@chromium.org

[commit-bot: I haz the power, 2014-02-28 11:57:31]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sergeyv@chromium.org/177653004/60001

[commit-bot: I haz the power, 2014-02-28 11:57:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-02-28 11:57:35]

Failed to apply patch for Source/devtools/front_end/inspector.js:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Source/devtools/front_end/inspector.js
  Hunk #3 FAILED at 869.
  1 out of 3 hunks FAILED -- saving rejects to file
Source/devtools/front_end/inspector.js.rej

Patch:       Source/devtools/front_end/inspector.js
Index: Source/devtools/front_end/inspector.js
diff --git a/Source/devtools/front_end/inspector.js
b/Source/devtools/front_end/inspector.js
index
6354e66ed4ada40c99d17d8c73bda64092e0c454..4e8c4860017c2b0744a087419c8253954e1d931b
100644
--- a/Source/devtools/front_end/inspector.js
+++ b/Source/devtools/front_end/inspector.js
@@ -343,7 +343,6 @@ WebInspector._doLoadedDoneWithCapabilities = function()
    
this.debuggerModel.addEventListener(WebInspector.DebuggerModel.Events.DebuggerPaused,
this._debuggerPaused, this);
     this.networkLog = new WebInspector.NetworkLog();
     this.domAgent = new WebInspector.DOMAgent();
-   
this.domAgent.addEventListener(WebInspector.DOMAgent.Events.InspectNodeRequested,
this._inspectNodeRequested, this);
     this.workerManager = new
WebInspector.WorkerManager(Capabilities.canInspectWorkers);
     this.runtimeModel = new WebInspector.RuntimeModel(this.resourceTreeModel);
 
@@ -810,14 +809,20 @@ WebInspector.inspect = function(payload, hints)
 {
     var object = WebInspector.RemoteObject.fromPayload(payload);
     if (object.subtype === "node") {
+
+        object.pushNodeToFrontend(callback);
+        var elementsPanel = /** @type {!WebInspector.ElementsPanel} */
WebInspector.panel("elements");
+        elementsPanel.omitDefaultSelection();
+        WebInspector.inspectorView.setCurrentPanel(elementsPanel);
+
         function callback(nodeId)
         {
-            WebInspector._updateFocusedNode(nodeId);
+            elementsPanel.stopOmittingDefaultSelection();
+           
WebInspector.Revealer.reveal(WebInspector.domAgent.nodeForId(nodeId));
             InspectorFrontendHost.inspectElementCompleted();
             object.release();
         }
-        object.pushNodeToFrontend(callback);
-        WebInspector.showPanel("elements");
+
         return;
     }
 
@@ -864,20 +869,6 @@ WebInspector.targetCrashed = function()
         WebInspector.UIString("Inspected target has crashed. Once it reloads we
will attach to it automatically."))).showModal();
 }
 
-WebInspector._inspectNodeRequested = function(event)
-{
-    WebInspector._updateFocusedNode(event.data);
-}
-
-WebInspector._updateFocusedNode = function(nodeId)
-{
-    if (WebInspector.inspectElementModeController &&
WebInspector.inspectElementModeController.enabled()) {
-        InspectorFrontendHost.bringToFront();
-        WebInspector.inspectElementModeController.disable();
-    }
-    WebInspector.showPanel("elements").revealAndSelectNode(nodeId);
-}
-
 WebInspector.evaluateInConsole = function(expression, showResultOnly)
 {
     this.showConsole();

[sergeyv, 2014-03-04 12:56:16]

The CQ bit was checked by sergeyv@chromium.org

[commit-bot: I haz the power, 2014-03-04 12:56:44]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sergeyv@chromium.org/177653004/80001

[commit-bot: I haz the power, 2014-03-05 18:02:15]

Change committed as 168503