Source/devtools/front_end/DOMAgent.js - Issue 177653004: DevTools: Get rid of redundant default selection during inspectElement

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/devtools/front_end/DOMAgent.js

Issue 177653004: DevTools: Get rid of redundant default selection during inspectElement (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Rebase on master Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/inspector/sources/debugger/debugger-command-line-api.html ('k') | Source/devtools/front_end/ElementsPanel.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/devtools/front_end/DOMAgent.js

diff --git a/Source/devtools/front_end/DOMAgent.js b/Source/devtools/front_end/DOMAgent.js

index 9e4a4fbc0e798309a8597db0cd4333aad2acf490..eccc4146c02eb2505cd7476c8a75881928b1e25b 100644

--- a/Source/devtools/front_end/DOMAgent.js

+++ b/Source/devtools/front_end/DOMAgent.js

@@ -777,7 +777,6 @@ WebInspector.DOMAgent.Events = {

ChildNodeCountUpdated: "ChildNodeCountUpdated",

UndoRedoRequested: "UndoRedoRequested",

UndoRedoCompleted: "UndoRedoCompleted",

- InspectNodeRequested: "InspectNodeRequested"

}

WebInspector.DOMAgent.prototype = {

@@ -1161,9 +1160,7 @@ WebInspector.DOMAgent.prototype = {

inspectElement: function(nodeId)

{

- var node = this._idToDOMNode[nodeId];

- if (node)

- this.dispatchEventToListeners(WebInspector.DOMAgent.Events.InspectNodeRequested, nodeId);

+ WebInspector.Revealer.reveal(this.nodeForId(nodeId));

/**

@@ -1171,7 +1168,7 @@ WebInspector.DOMAgent.prototype = {

_inspectNodeRequested: function(nodeId)

{

- this.dispatchEventToListeners(WebInspector.DOMAgent.Events.InspectNodeRequested, nodeId);

+ this.inspectElement(nodeId);

/**