Issue 177653003: Free HashSets on setWholeSubtreeInvalid.

Issue 177653003: Free HashSets on setWholeSubtreeInvalid. (Closed)

Created:
6 years, 10 months ago by rune

Modified:
6 years, 10 months ago

Reviewers:
chrishtr, esprehn, ojan

CC:
blink-reviews, ed+blinkwatch_opera.com, dglazkov+blink, apavlov+blink_chromium.org, darktears, rune+blink, rwlbuis

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Free HashSets on setWholeSubtreeInvalid. In order to keep memory use as low as possible, free any HashSets which are allocated in DescendantInvalidationSets when setWholeSubtreeInvalid is called. Also ensure that none of the HashSets are re-created in a DescendantInvalidationSet when wholeSubtreeInvalid is already true. Additionally fixed some constness and removed non-existing method from header file. R=esprehn@chromium.org, chrishtr@chromium.org BUG=335247 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=167709

Patch Set 1 #

Total comments: 2

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+104 lines, -7 lines)			Patch
M	Source/core/core.gypi	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	Source/core/css/analyzer/DescendantInvalidationSet.h	View	3 chunks	+14 lines, -4 lines	2 comments	Download
M	Source/core/css/analyzer/DescendantInvalidationSet.cpp	View	2 chunks	+13 lines, -3 lines	0 comments	Download
A	Source/core/css/analyzer/DescendantInvalidationSetTest.cpp	View	1 chunk	+76 lines, -0 lines	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rune@opera.com/177653003/1

6 years, 10 months ago (2014-02-24 18:47:53 UTC) #5

ojan

https://codereview.chromium.org/177653003/diff/1/Source/core/css/analyzer/DescendantInvalidationSet.h File Source/core/css/analyzer/DescendantInvalidationSet.h (right): https://codereview.chromium.org/177653003/diff/1/Source/core/css/analyzer/DescendantInvalidationSet.h#newcode81 Source/core/css/analyzer/DescendantInvalidationSet.h:81: inline void DescendantInvalidationSet::setWholeSubtreeInvalid() Did you actually see performance difference ...

6 years, 10 months ago (2014-02-25 00:30:53 UTC) #7

rune

6 years, 10 months ago (2014-02-25 08:36:16 UTC) #8

Message was sent while issue was closed.

https://codereview.chromium.org/177653003/diff/1/Source/core/css/analyzer/Des...
File Source/core/css/analyzer/DescendantInvalidationSet.h (right):

https://codereview.chromium.org/177653003/diff/1/Source/core/css/analyzer/Des...
Source/core/css/analyzer/DescendantInvalidationSet.h:81: inline void
DescendantInvalidationSet::setWholeSubtreeInvalid()
On 2014/02/25 00:30:53, ojan wrote:
> Did you actually see performance difference in making this inline or just
> keeping it inline because it used to be so before? If the former, LGTM. If the
> latter, I'd prefer that this be moved to the cpp file and not inlined. 

https://codereview.chromium.org/179483002/

Expand Messages | Collapse Messages