Chromium Code Reviews| OLD | NEW |
|---|---|
| 1 /* | 1 /* |
| 2 * Copyright (C) 2014 Google Inc. All rights reserved. | 2 * Copyright (C) 2014 Google Inc. All rights reserved. |
| 3 * | 3 * |
| 4 * Redistribution and use in source and binary forms, with or without | 4 * Redistribution and use in source and binary forms, with or without |
| 5 * modification, are permitted provided that the following conditions are | 5 * modification, are permitted provided that the following conditions are |
| 6 * met: | 6 * met: |
| 7 * | 7 * |
| 8 * * Redistributions of source code must retain the above copyright | 8 * * Redistributions of source code must retain the above copyright |
| 9 * notice, this list of conditions and the following disclaimer. | 9 * notice, this list of conditions and the following disclaimer. |
| 10 * * Redistributions in binary form must reproduce the above | 10 * * Redistributions in binary form must reproduce the above |
| (...skipping 40 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 51 return adoptRef(new DescendantInvalidationSet); | 51 return adoptRef(new DescendantInvalidationSet); |
| 52 } | 52 } |
| 53 | 53 |
| 54 void combine(const DescendantInvalidationSet& other); | 54 void combine(const DescendantInvalidationSet& other); |
| 55 | 55 |
| 56 void addClass(const AtomicString& className); | 56 void addClass(const AtomicString& className); |
| 57 void addId(const AtomicString& id); | 57 void addId(const AtomicString& id); |
| 58 void addTagName(const AtomicString& tagName); | 58 void addTagName(const AtomicString& tagName); |
| 59 | 59 |
| 60 // Appends the classes in this DescendantInvalidationSet to the vector. | 60 // Appends the classes in this DescendantInvalidationSet to the vector. |
| 61 void getClasses(Vector<AtomicString>& classes); | 61 void getClasses(Vector<AtomicString>& classes) const; |
| 62 | 62 |
| 63 void setWholeSubtreeInvalid() { m_allDescendantsMightBeInvalid = true; }; | 63 void setWholeSubtreeInvalid(); |
| 64 bool wholeSubtreeInvalid() { return m_allDescendantsMightBeInvalid; } | 64 bool wholeSubtreeInvalid() const { return m_allDescendantsMightBeInvalid; } |
| 65 private: | 65 private: |
| 66 DescendantInvalidationSet(); | 66 DescendantInvalidationSet(); |
| 67 | 67 |
| 68 HashSet<AtomicString>& ensureClassSet(); | 68 HashSet<AtomicString>& ensureClassSet(); |
| 69 HashSet<AtomicString>& ensureIdSet(); | 69 HashSet<AtomicString>& ensureIdSet(); |
| 70 HashSet<AtomicString>& ensureTagNameSet(); | 70 HashSet<AtomicString>& ensureTagNameSet(); |
| 71 | 71 |
| 72 bool invalidateElementSubtreeInternal(Element*); | |
| 73 // If true, all descendants might be invalidated, so a full subtree recalc i s required. | 72 // If true, all descendants might be invalidated, so a full subtree recalc i s required. |
| 74 bool m_allDescendantsMightBeInvalid; | 73 bool m_allDescendantsMightBeInvalid; |
| 75 | 74 |
| 76 // FIXME: optimize this if it becomes a memory issue. | 75 // FIXME: optimize this if it becomes a memory issue. |
| 77 OwnPtr<HashSet<AtomicString> > m_classes; | 76 OwnPtr<HashSet<AtomicString> > m_classes; |
| 78 OwnPtr<HashSet<AtomicString> > m_ids; | 77 OwnPtr<HashSet<AtomicString> > m_ids; |
| 79 OwnPtr<HashSet<AtomicString> > m_tagNames; | 78 OwnPtr<HashSet<AtomicString> > m_tagNames; |
| 80 }; | 79 }; |
| 81 | 80 |
| 81 inline void DescendantInvalidationSet::setWholeSubtreeInvalid() | |
|
ojan
2014/02/25 00:30:53
Did you actually see performance difference in mak
rune
2014/02/25 08:36:17
https://codereview.chromium.org/179483002/
| |
| 82 { | |
| 83 if (m_allDescendantsMightBeInvalid) | |
| 84 return; | |
| 85 | |
| 86 m_allDescendantsMightBeInvalid = true; | |
| 87 m_classes = nullptr; | |
| 88 m_ids = nullptr; | |
| 89 m_tagNames = nullptr; | |
| 90 } | |
| 91 | |
| 82 } // namespace WebCore | 92 } // namespace WebCore |
| 83 | 93 |
| 84 #endif // DescendantInvalidationSet_h | 94 #endif // DescendantInvalidationSet_h |
| OLD | NEW |