Allow client process information to be passed via Connector::Connect().

Allow client process information to be passed via Connector::Connect().

This allows applications to start processes themselves and have the shell use them instead of starting its own.
Allows us to eliminate Shell::CreateInstance().

BUG=
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation

Committed: https://crrev.com/40b6dc773e28490f14eaea639261c82154d948a0
Cr-Commit-Position: refs/heads/master@{#380030}

[Ben Goodger (Google), 2016-03-08 20:57:43]

Description was changed from

==========
Allow client process information to be passed via Connector::Connect().

This allows applications to start processes themselves and have the shell use
them instead of starting its own.
Allows us to eliminate Shell::CreateInstance().

BUG=
==========

to

==========
Allow client process information to be passed via Connector::Connect().

This allows applications to start processes themselves and have the shell use
them instead of starting its own.
Allows us to eliminate Shell::CreateInstance().

BUG=
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

[Ben Goodger (Google), 2016-03-08 21:23:10]

ben@chromium.org changed reviewers:
+ sky@chromium.org

[sky, 2016-03-08 22:30:24]

LGTM

https://codereview.chromium.org/1776513003/diff/60001/content/browser/mojo/mo...
File content/browser/mojo/mojo_child_connection.cc (right):

https://codereview.chromium.org/1776513003/diff/60001/content/browser/mojo/mo...
content/browser/mojo/mojo_child_connection.cc:77: host_ = nullptr;
I'm surprised you don't delete this here too. Maybe the the error handler takes
care of it?

https://codereview.chromium.org/1776513003/diff/60001/content/browser/mojo/mo...
content/browser/mojo/mojo_child_connection.cc:109: new
PIDSender(render_process_host, std::move(pid_receiver));
nit: mention PIDSender maintains its own lifetime.

https://codereview.chromium.org/1776513003/diff/60001/content/browser/mojo/mo...
File content/browser/mojo/mojo_child_connection.h (right):

https://codereview.chromium.org/1776513003/diff/60001/content/browser/mojo/mo...
content/browser/mojo/mojo_child_connection.h:1: // Copyright 2015 The Chromium
Authors. All rights reserved.
2016

[Ben Goodger (Google), 2016-03-08 23:55:44]

The CQ bit was checked by ben@chromium.org

[Ben Goodger (Google), 2016-03-08 23:55:44]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org
Link to the patchset: https://codereview.chromium.org/1776513003/#ps80001
(title: ".")

[commit-bot: I haz the power, 2016-03-08 23:56:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1776513003/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1776513003/80001

[commit-bot: I haz the power, 2016-03-09 01:53:37]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-03-09 01:55:38]

Description was changed from

==========
Allow client process information to be passed via Connector::Connect().

This allows applications to start processes themselves and have the shell use
them instead of starting its own.
Allows us to eliminate Shell::CreateInstance().

BUG=
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Allow client process information to be passed via Connector::Connect().

This allows applications to start processes themselves and have the shell use
them instead of starting its own.
Allows us to eliminate Shell::CreateInstance().

BUG=
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation

Committed: https://crrev.com/40b6dc773e28490f14eaea639261c82154d948a0
Cr-Commit-Position: refs/heads/master@{#380030}
==========

[commit-bot: I haz the power, 2016-03-09 01:55:39]

Patchset 5 (id:??) landed as
https://crrev.com/40b6dc773e28490f14eaea639261c82154d948a0
Cr-Commit-Position: refs/heads/master@{#380030}

[Ken Rockot(use gerrit already), 2016-03-09 18:25:13]

rockot@chromium.org changed reviewers:
+ rockot@chromium.org

[Ken Rockot(use gerrit already), 2016-03-09 18:25:14]

Lots of Chrome OS browser_tests failures with shell connection error spam,
starting when this CL landed:

https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%...

Any ideas?

[Ben Goodger (Google), 2016-03-09 20:26:13]

I'll take a look this afternoon.

On Wed, Mar 9, 2016 at 10:25 AM, <rockot@chromium.org> wrote:

> Lots of Chrome OS browser_tests failures with shell connection error spam,
> starting when this CL landed:
>
>
>
https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%...
>
> Any ideas?
>
> https://codereview.chromium.org/1776513003/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.