Only MarkTrailersConsumed when actually sending trailers notification

Only MarkTrailersConsumed when actually sending trailers notification

MarkTrailersConsumed is currently done before the
notification is posted asynchronously. However, there might
be a pending read  before that notification is executed but
after  MarkTrailersConsumed, which leads to delegate
mistakenly to assume that the trailers are consumed.
This CL changes so that we MarkTrailersConsumed when we
actually will immediately notify delegate.

This CL also patches some internal trailers changes in
quic_spdy_stream.cc and quic_spdy_client_stream.cc.

BUG=586207
Committed: https://crrev.com/188bd40f723812b8a718195fdc5af274c21891e4
Cr-Commit-Position: refs/heads/master@{#380799}

[xunjieli, 2016-03-09 21:06:44]

Description was changed from

==========
temp

BUG=
==========

to

==========
Only MarkTrailersConsumed when actually sending trailers notification

MarkTrailersConsumed is currently done before the notification is posted
asynchronously. However, there might 
be a pending read  before that notification is executed but after 
MarkTrailersConsumed, which leads to delegate 
mistakenly to assume that the trailers are consumed.

BUG=586207
==========

[xunjieli, 2016-03-09 21:08:03]

Description was changed from

==========
Only MarkTrailersConsumed when actually sending trailers notification

MarkTrailersConsumed is currently done before the notification is posted
asynchronously. However, there might 
be a pending read  before that notification is executed but after 
MarkTrailersConsumed, which leads to delegate 
mistakenly to assume that the trailers are consumed.

BUG=586207
==========

to

==========
Only MarkTrailersConsumed when actually sending trailers notification

MarkTrailersConsumed is currently done before the 
notification is posted asynchronously. However, there might 
be a pending read  before that notification is executed but 
after  MarkTrailersConsumed, which leads to delegate 
mistakenly to assume that the trailers are consumed.
This CL changes so that we MarkTrailersConsumed when we 
actually will immediately notify delegate.

BUG=586207
==========

[xunjieli, 2016-03-09 21:08:14]

Patchset #1 (id:1) has been deleted

[xunjieli, 2016-03-09 21:13:45]

Patchset #1 (id:20001) has been deleted

[xunjieli, 2016-03-09 21:16:14]

xunjieli@chromium.org changed reviewers:
+ rch@chromium.org

[xunjieli, 2016-03-09 21:16:15]

Ryan, could you take a look? (cc-ed Robbie.)

[Ryan Hamilton, 2016-03-09 22:35:01]

Can you add a unit test?

[xunjieli, 2016-03-10 19:36:25]

Patchset #2 (id:60001) has been deleted

[xunjieli, 2016-03-10 20:04:30]

On 2016/03/09 22:35:01, Ryan Hamilton wrote:
> Can you add a unit test?

Great suggestion! I have added a unit test that will fail without this patch.
Done. PTAL.

[xunjieli, 2016-03-11 16:28:15]

Patchset #3 (id:100001) has been deleted

[xunjieli, 2016-03-11 19:29:18]

Patchset #3 (id:120001) has been deleted

[xunjieli, 2016-03-11 22:14:53]

Description was changed from

==========
Only MarkTrailersConsumed when actually sending trailers notification

MarkTrailersConsumed is currently done before the 
notification is posted asynchronously. However, there might 
be a pending read  before that notification is executed but 
after  MarkTrailersConsumed, which leads to delegate 
mistakenly to assume that the trailers are consumed.
This CL changes so that we MarkTrailersConsumed when we 
actually will immediately notify delegate.

BUG=586207
==========

to

==========
Only MarkTrailersConsumed when actually sending trailers notification

MarkTrailersConsumed is currently done before the 
notification is posted asynchronously. However, there might 
be a pending read  before that notification is executed but 
after  MarkTrailersConsumed, which leads to delegate 
mistakenly to assume that the trailers are consumed.
This CL changes so that we MarkTrailersConsumed when we 
actually will immediately notify delegate.

This CL also patches some internal trailers changes in
quic_spdy_stream.cc and quic_spdy_client_stream.cc.
BUG=586207
==========

[xunjieli, 2016-03-11 22:15:02]

Description was changed from

==========
Only MarkTrailersConsumed when actually sending trailers notification

MarkTrailersConsumed is currently done before the 
notification is posted asynchronously. However, there might 
be a pending read  before that notification is executed but 
after  MarkTrailersConsumed, which leads to delegate 
mistakenly to assume that the trailers are consumed.
This CL changes so that we MarkTrailersConsumed when we 
actually will immediately notify delegate.

This CL also patches some internal trailers changes in
quic_spdy_stream.cc and quic_spdy_client_stream.cc.
BUG=586207
==========

to

==========
Only MarkTrailersConsumed when actually sending trailers notification

MarkTrailersConsumed is currently done before the 
notification is posted asynchronously. However, there might 
be a pending read  before that notification is executed but 
after  MarkTrailersConsumed, which leads to delegate 
mistakenly to assume that the trailers are consumed.
This CL changes so that we MarkTrailersConsumed when we 
actually will immediately notify delegate.

This CL also patches some internal trailers changes in
quic_spdy_stream.cc and quic_spdy_client_stream.cc.

BUG=586207
==========

[xunjieli, 2016-03-11 22:18:15]

Patchset #3 (id:140001) has been deleted

[xunjieli, 2016-03-11 22:20:37]

Ryan, PTAL. I have also included internal changes on trailers and fixed affected
tests. Once I get this landed, I can land the BidirectionalStreamQuicImpl CL.
Thanks!

[Ryan Hamilton, 2016-03-11 23:44:03]

lgtm

[xunjieli, 2016-03-11 23:46:53]

On 2016/03/11 23:44:03, Ryan Hamilton wrote:
> lgtm

Thanks a lot for the quick response!

[xunjieli, 2016-03-11 23:46:59]

The CQ bit was checked by xunjieli@chromium.org

[commit-bot: I haz the power, 2016-03-11 23:47:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1776423004/160001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1776423004/160001

[commit-bot: I haz the power, 2016-03-12 00:17:32]

Description was changed from

==========
Only MarkTrailersConsumed when actually sending trailers notification

MarkTrailersConsumed is currently done before the 
notification is posted asynchronously. However, there might 
be a pending read  before that notification is executed but 
after  MarkTrailersConsumed, which leads to delegate 
mistakenly to assume that the trailers are consumed.
This CL changes so that we MarkTrailersConsumed when we 
actually will immediately notify delegate.

This CL also patches some internal trailers changes in
quic_spdy_stream.cc and quic_spdy_client_stream.cc.

BUG=586207
==========

to

==========
Only MarkTrailersConsumed when actually sending trailers notification

MarkTrailersConsumed is currently done before the 
notification is posted asynchronously. However, there might 
be a pending read  before that notification is executed but 
after  MarkTrailersConsumed, which leads to delegate 
mistakenly to assume that the trailers are consumed.
This CL changes so that we MarkTrailersConsumed when we 
actually will immediately notify delegate.

This CL also patches some internal trailers changes in
quic_spdy_stream.cc and quic_spdy_client_stream.cc.

BUG=586207
==========

[commit-bot: I haz the power, 2016-03-12 00:17:33]

Committed patchset #3 (id:160001)

[commit-bot: I haz the power, 2016-03-12 00:20:04]

Description was changed from

==========
Only MarkTrailersConsumed when actually sending trailers notification

MarkTrailersConsumed is currently done before the 
notification is posted asynchronously. However, there might 
be a pending read  before that notification is executed but 
after  MarkTrailersConsumed, which leads to delegate 
mistakenly to assume that the trailers are consumed.
This CL changes so that we MarkTrailersConsumed when we 
actually will immediately notify delegate.

This CL also patches some internal trailers changes in
quic_spdy_stream.cc and quic_spdy_client_stream.cc.

BUG=586207
==========

to

==========
Only MarkTrailersConsumed when actually sending trailers notification

MarkTrailersConsumed is currently done before the
notification is posted asynchronously. However, there might
be a pending read  before that notification is executed but
after  MarkTrailersConsumed, which leads to delegate
mistakenly to assume that the trailers are consumed.
This CL changes so that we MarkTrailersConsumed when we
actually will immediately notify delegate.

This CL also patches some internal trailers changes in
quic_spdy_stream.cc and quic_spdy_client_stream.cc.

BUG=586207

Committed: https://crrev.com/188bd40f723812b8a718195fdc5af274c21891e4
Cr-Commit-Position: refs/heads/master@{#380799}
==========

[commit-bot: I haz the power, 2016-03-12 00:20:05]

Patchset 3 (id:??) landed as
https://crrev.com/188bd40f723812b8a718195fdc5af274c21891e4
Cr-Commit-Position: refs/heads/master@{#380799}