Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(466)

Unified Diff: net/tools/quic/quic_spdy_client_stream.cc

Issue 1776423004: Only MarkTrailersConsumed when actually sending trailers notification (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add internal changes and fix tests Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/tools/quic/quic_spdy_client_stream.h ('k') | net/tools/quic/test_tools/quic_test_client.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/tools/quic/quic_spdy_client_stream.cc
diff --git a/net/tools/quic/quic_spdy_client_stream.cc b/net/tools/quic/quic_spdy_client_stream.cc
index 12289364bc1aba2d6976a7b13f72165bf1635b5d..615fab476ea02898ea6abfabe1f39b492c2835dc 100644
--- a/net/tools/quic/quic_spdy_client_stream.cc
+++ b/net/tools/quic/quic_spdy_client_stream.cc
@@ -72,20 +72,8 @@ void QuicSpdyClientStream::OnInitialHeadersComplete(bool fin,
void QuicSpdyClientStream::OnTrailingHeadersComplete(bool fin,
size_t frame_len) {
- size_t final_byte_offset = 0;
- if (!SpdyUtils::ParseTrailers(decompressed_trailers().data(),
- decompressed_trailers().length(),
- &final_byte_offset, &response_trailers_)) {
- Reset(QUIC_BAD_APPLICATION_PAYLOAD);
- return;
- }
+ QuicSpdyStream::OnTrailingHeadersComplete(fin, frame_len);
MarkTrailersConsumed(decompressed_trailers().length());
-
- // The data on this stream ends at |final_byte_offset|.
- DVLOG(1) << "Stream ends at byte offset: " << final_byte_offset
- << " currently read: " << stream_bytes_read();
- OnStreamFrame(
- QuicStreamFrame(id(), /*fin=*/true, final_byte_offset, StringPiece()));
}
void QuicSpdyClientStream::OnPromiseHeadersComplete(QuicStreamId promised_id,
« no previous file with comments | « net/tools/quic/quic_spdy_client_stream.h ('k') | net/tools/quic/test_tools/quic_test_client.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698