Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3159)

Unified Diff: chrome/browser/ui/webui/settings/people_handler.h

Issue 1776393003: MD Settings: avoid double pref observation on Startup Pages (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: unordered_set Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/settings/people_handler.h
diff --git a/chrome/browser/ui/webui/settings/people_handler.h b/chrome/browser/ui/webui/settings/people_handler.h
index 0ae1476e8aceb965145a9d894f49303e50280edf..4556b740f2a891dccdc71d3af9e2baa08e3e651e 100644
--- a/chrome/browser/ui/webui/settings/people_handler.h
+++ b/chrome/browser/ui/webui/settings/people_handler.h
@@ -14,11 +14,11 @@
#include "build/build_config.h"
#include "chrome/browser/profiles/profile_attributes_storage.h"
#include "chrome/browser/sync/sync_startup_tracker.h"
+#include "chrome/browser/ui/webui/settings/md_settings_ui.h"
#include "chrome/browser/ui/webui/signin/login_ui_service.h"
#include "components/prefs/pref_change_registrar.h"
#include "components/signin/core/browser/signin_manager_base.h"
#include "components/sync_driver/sync_service_observer.h"
-#include "content/public/browser/web_ui_message_handler.h"
#if defined(OS_CHROMEOS)
#include "content/public/browser/notification_observer.h"
@@ -40,7 +40,7 @@ enum class AccessPoint;
namespace settings {
-class PeopleHandler : public content::WebUIMessageHandler,
+class PeopleHandler : public SettingsPageUIHandler,
michaelpg 2016/03/11 01:16:54 why?
Dan Beam 2016/03/11 05:39:06 I restricted AddSettingsPageUIHandler() to take a
public SigninManagerBase::Observer,
public SyncStartupTracker::Observer,
public LoginUIService::LoginUI,
@@ -53,7 +53,7 @@ class PeopleHandler : public content::WebUIMessageHandler,
explicit PeopleHandler(Profile* profile);
~PeopleHandler() override;
- // content::WebUIMessageHandler implementation.
+ // SettingsPageUIHandler implementation.
void RegisterMessages() override;
// SyncStartupTracker::Observer implementation.

Powered by Google App Engine
This is Rietveld 408576698