MD Settings: avoid double pref observation on Startup Pages

chrome/browser/ui/webui/settings/md_settings_ui.h

Index: chrome/browser/ui/webui/settings/md_settings_ui.h
diff --git a/chrome/browser/ui/webui/settings/md_settings_ui.h b/chrome/browser/ui/webui/settings/md_settings_ui.h
index 301f4f25c38269f754eac18ed208f54778c377b5..b73ffb522a5b44a29299b47fa8e064975fa6c442 100644
--- a/chrome/browser/ui/webui/settings/md_settings_ui.h
+++ b/chrome/browser/ui/webui/settings/md_settings_ui.h
@@ -6,7 +6,7 @@
 #define CHROME_BROWSER_UI_WEBUI_SETTINGS_MD_SETTINGS_UI_H_
 
 #include <string>
-#include <vector>
+#include <unordered_set>
 
 #include "base/macros.h"
 #include "base/memory/scoped_ptr.h"
@@ -24,9 +24,12 @@ class SettingsPageUIHandler : public content::WebUIMessageHandler {
   SettingsPageUIHandler();
   ~SettingsPageUIHandler() override;
 
-  // WebUIMessageHandler implementation.
+  // WebUIMessageHandler:
   void RegisterMessages() override {}
 
+  // TODO(dbeam): move to WebUIMessageHandler?
+  virtual void RenderViewReused() {}

[michaelpg, 2016/03/11 01:16:54]

plz comment what this is

[Dan Beam, 2016/03/11 05:39:06]

Done.

+
  protected:
   // Helper method for responding to JS requests initiated with
   // cr.sendWithPromise(), for the case where the returned promise should be
@@ -51,7 +54,10 @@ class MdSettingsUI : public content::WebUIController,
   explicit MdSettingsUI(content::WebUI* web_ui);
   ~MdSettingsUI() override;
 
-  // Overridden from content::WebContentsObserver:
+  // content::WebUIController:
+  void RenderViewReused(content::RenderViewHost* render_view_host) override;
+
+  // content::WebContentsObserver:
   void DidStartProvisionalLoadForFrame(
       content::RenderFrameHost* render_frame_host,
       const GURL& validated_url,
@@ -62,7 +68,10 @@ class MdSettingsUI : public content::WebUIController,
   void DocumentOnLoadCompletedInMainFrame() override;
 
  private:
-  void AddSettingsPageUIHandler(content::WebUIMessageHandler* handler);
+  void AddSettingsPageUIHandler(SettingsPageUIHandler* handler);
+
+  // Weak references; all |handlers_| are owned by |web_ui()|.

[michaelpg, 2016/03/11 01:16:54]

asking out of ignorance: web_ui() exists here from ctor to dtor?

(also added question to
https://docs.google.com/document/d/1ubLoYnTSyjCMFCpy1tPy6g1RAm5FajmbuQygjqN3a...)

[Dan Beam, 2016/03/11 05:39:06]

yes

https://code.google.com/p/chromium/codesearch#chromium/src/content/public/bro...

+  std::unordered_set<SettingsPageUIHandler*> handlers_;
 
   base::Time load_start_time_;