Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(942)

Issue 1776373002: [Extensions] Remove unused parts of the preferencesPrivate API (Closed)

Created:
4 years, 9 months ago by Devlin
Modified:
4 years, 9 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, asvitkine+watch_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Extensions] Remove unused parts of the preferencesPrivate API easyUnlockProximityRequired might still be used by someone, but it looks like the rest of this API can be removed. BUG=593166 TBR=erg@chromium.org (profiles/ pref change reviewed by gab@) Committed: https://crrev.com/76ea109e501ad804a4539f61028515d7ff9b7e07 Cr-Commit-Position: refs/heads/master@{#381278}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Also prefs #

Patch Set 3 : Clean Up Prefs #

Total comments: 3

Patch Set 4 : Really clean up prefs #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -362 lines) Patch
M chrome/browser/extensions/api/preference/chrome_direct_setting_api.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
D chrome/browser/extensions/api/preferences_private/preferences_private_api.h View 1 chunk +0 lines, -41 lines 0 comments Download
D chrome/browser/extensions/api/preferences_private/preferences_private_api.cc View 1 chunk +0 lines, -69 lines 0 comments Download
D chrome/browser/extensions/api/preferences_private/preferences_private_apitest.cc View 1 2 1 chunk +0 lines, -209 lines 0 comments Download
M chrome/browser/prefs/browser_prefs.cc View 1 2 3 3 chunks +15 lines, -0 lines 0 comments Download
M chrome/browser/profiles/profile.cc View 1 3 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/chrome_browser_extensions.gypi View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/extensions/api/preferences_private.json View 1 chunk +1 line, -27 lines 0 comments Download
M chrome/common/pref_names.h View 1 2 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/common/pref_names.cc View 1 2 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 28 (10 generated)
Devlin
4 years, 9 months ago (2016-03-09 22:00:51 UTC) #2
asargent_no_longer_on_chrome
https://codereview.chromium.org/1776373002/diff/1/chrome/common/extensions/api/preferences_private.json File chrome/common/extensions/api/preferences_private.json (left): https://codereview.chromium.org/1776373002/diff/1/chrome/common/extensions/api/preferences_private.json#oldcode19 chrome/common/extensions/api/preferences_private.json:19: "value": ["googlegeolocationaccess.enabled", {"type":"boolean"}], I think you also want to ...
4 years, 9 months ago (2016-03-09 23:07:44 UTC) #3
Devlin
Note also that I removed the histogram updates from this CL since it emits a ...
4 years, 9 months ago (2016-03-10 19:08:41 UTC) #4
asargent_no_longer_on_chrome
> Good call! It also looks like that was the only time we used that ...
4 years, 9 months ago (2016-03-10 22:35:28 UTC) #5
Devlin
On 2016/03/10 22:35:28, Antony Sargent wrote: > > Good call! It also looks like that ...
4 years, 9 months ago (2016-03-10 22:47:54 UTC) #6
Devlin
+gab@ (a lucky owner of components/prefs) for a prefs question: If we wanna remove a ...
4 years, 9 months ago (2016-03-10 22:49:34 UTC) #8
asargent_no_longer_on_chrome
lgtm
4 years, 9 months ago (2016-03-11 16:56:33 UTC) #9
Devlin
gab@, friendly ping?
4 years, 9 months ago (2016-03-14 17:39:50 UTC) #10
gab
On 2016/03/10 22:49:34, Devlin wrote: > +gab@ (a lucky owner of components/prefs) for a prefs ...
4 years, 9 months ago (2016-03-14 18:32:27 UTC) #11
Devlin
On 2016/03/14 18:32:27, gab wrote: > On 2016/03/10 22:49:34, Devlin wrote: > > +gab@ (a ...
4 years, 9 months ago (2016-03-14 20:52:32 UTC) #12
gab
lgtm w/ comment https://codereview.chromium.org/1776373002/diff/40001/chrome/browser/prefs/browser_prefs.cc File chrome/browser/prefs/browser_prefs.cc (right): https://codereview.chromium.org/1776373002/diff/40001/chrome/browser/prefs/browser_prefs.cc#newcode675 chrome/browser/prefs/browser_prefs.cc:675: profile_prefs->ClearPref(kGoogleGeolocationAccessEnabled); From its location in pref_names.cc ...
4 years, 9 months ago (2016-03-14 20:57:36 UTC) #13
Devlin
https://codereview.chromium.org/1776373002/diff/40001/chrome/browser/prefs/browser_prefs.cc File chrome/browser/prefs/browser_prefs.cc (right): https://codereview.chromium.org/1776373002/diff/40001/chrome/browser/prefs/browser_prefs.cc#newcode675 chrome/browser/prefs/browser_prefs.cc:675: profile_prefs->ClearPref(kGoogleGeolocationAccessEnabled); On 2016/03/14 20:57:36, gab wrote: > From its ...
4 years, 9 months ago (2016-03-14 21:19:52 UTC) #15
gab
prefs lgtm++, thanks https://codereview.chromium.org/1776373002/diff/40001/chrome/browser/prefs/browser_prefs.cc File chrome/browser/prefs/browser_prefs.cc (right): https://codereview.chromium.org/1776373002/diff/40001/chrome/browser/prefs/browser_prefs.cc#newcode675 chrome/browser/prefs/browser_prefs.cc:675: profile_prefs->ClearPref(kGoogleGeolocationAccessEnabled); On 2016/03/14 21:19:52, Devlin wrote: ...
4 years, 9 months ago (2016-03-15 01:20:29 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1776373002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1776373002/80001
4 years, 9 months ago (2016-03-15 17:11:33 UTC) #20
commit-bot: I haz the power
Try jobs failed on following builders: win8_chromium_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/builds/117666)
4 years, 9 months ago (2016-03-15 18:03:54 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1776373002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1776373002/80001
4 years, 9 months ago (2016-03-15 18:58:19 UTC) #24
commit-bot: I haz the power
Committed patchset #4 (id:80001)
4 years, 9 months ago (2016-03-15 19:20:15 UTC) #26
commit-bot: I haz the power
4 years, 9 months ago (2016-03-15 19:21:29 UTC) #28
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/76ea109e501ad804a4539f61028515d7ff9b7e07
Cr-Commit-Position: refs/heads/master@{#381278}

Powered by Google App Engine
This is Rietveld 408576698