[Extensions] Remove unused parts of the preferencesPrivate API

chrome/browser/prefs/browser_prefs.cc

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/prefs/browser_prefs.h"
 
 #include <string>
 
 #include "base/metrics/histogram_macros.h"
 #include "base/trace_event/trace_event.h"
@@ skipping 257 matching lines @@
 const char kOverscrollMinimumThresholdStartTouchpad[] =
     "overscroll.minimum_threshold_start_touchpad";
 const char kOverscrollVerticalThresholdStart[] =
     "overscroll.vertical_threshold_start";
 const char kOverscrollHorizontalResistThreshold[] =
     "overscroll.horizontal_resist_threshold";
 const char kOverscrollVerticalResistThreshold[] =
     "overscroll.vertical_resist_threshold";
 #endif  // defined(USE_AURA)
 
+#if BUILDFLAG(ENABLE_GOOGLE_NOW)
+// Deprecated 3/2016
+const char kGoogleGeolocationAccessEnabled[] =;
+    "googlegeolocationaccess.enabled";
+#endif
+
 }  // namespace
 
 namespace chrome {
 
 void RegisterLocalState(PrefRegistrySimple* registry) {
   // Please keep this list alphabetized.
   AppListService::RegisterPrefs(registry);
   browser_shutdown::RegisterPrefs(registry);
   BrowserProcessImpl::RegisterPrefs(registry);
   ChromeMetricsServiceClient::RegisterPrefs(registry);
@@ skipping 368 matching lines @@
   profile_prefs->ClearPref(kMaxSeparationForGestureTouchesInPixels);
   profile_prefs->ClearPref(kSemiLongPressTimeInMs);
   profile_prefs->ClearPref(kOverscrollHorizontalThresholdComplete);
   profile_prefs->ClearPref(kOverscrollVerticalThresholdComplete);
   profile_prefs->ClearPref(kOverscrollMinimumThresholdStart);
   profile_prefs->ClearPref(kOverscrollMinimumThresholdStartTouchpad);
   profile_prefs->ClearPref(kOverscrollVerticalThresholdStart);
   profile_prefs->ClearPref(kOverscrollHorizontalResistThreshold);
   profile_prefs->ClearPref(kOverscrollVerticalResistThreshold);
 #endif  // defined(USE_AURA)
+
+#if BUILDFLAG(ENABLE_GOOGLE_NOW)
+  // Added 3/2016.
+  profile_prefs->ClearPref(kGoogleGeolocationAccessEnabled);

[gab, 2016/03/14 20:57:36]

From its location in pref_names.cc I gather that this was a Local State pref? If
so it needs to be cleared in MigrateObsoleteBrowserPrefs() above, not in
MigrateObsoleteProfilePrefs() which is for obsolete per-profile Preferences.

[Devlin, 2016/03/14 21:19:52]

Detangling this pref is kind of a pain, but I think it was misplaced in the
pref_names file.  The pref is read at [1] and [2] and is set at [3] and [4], all
of which use the pref service from Profile::GetPrefs().  Does that sound right
to you?

[1]
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/ext...
[2]
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/ext...
[3]
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/ext...
[4]
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/ext...

[gab, 2016/03/15 01:20:29]

Ah ok, that sounds right then, had only based my reading on its position in the
file (TBH that file is a humongous mess and trusting it was incorrect of me in
the first place!)

+#endif
 }
 
 }  // namespace chrome