Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2875)

Issue 1776353002: Split off api-arguments.[h|cc] from arguments.[h|cc] (Closed)

Created:
4 years, 9 months ago by Toon Verwaest
Modified:
4 years, 9 months ago
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-x87-ports_googlegroups.com, v8-ppc-ports_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Split off api-arguments.[h|cc] from arguments.[h|cc] NOPRESUBMIT=true BUG= Committed: https://crrev.com/5c73b25ff58e32bcd69153de15a786210769426c Cr-Commit-Position: refs/heads/master@{#34664}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -438 lines) Patch
M BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
A + src/api-arguments.h View 8 chunks +22 lines, -123 lines 0 comments Download
A + src/api-arguments.cc View 8 chunks +3 lines, -21 lines 0 comments Download
M src/arguments.h View 2 chunks +1 line, -194 lines 0 comments Download
M src/arguments.cc View 2 chunks +0 lines, -85 lines 0 comments Download
M src/arm/code-stubs-arm.cc View 1 chunk +2 lines, -1 line 1 comment Download
M src/arm64/code-stubs-arm64.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/builtins.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/ic/arm/handler-compiler-arm.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/ic/arm64/handler-compiler-arm64.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/ic/ia32/handler-compiler-ia32.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/ic/ic.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M src/ic/mips/handler-compiler-mips.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/ic/mips64/handler-compiler-mips64.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/ic/ppc/handler-compiler-ppc.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/ic/s390/handler-compiler-s390.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/ic/x64/handler-compiler-x64.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/ic/x87/handler-compiler-x87.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/mips/code-stubs-mips.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/mips64/code-stubs-mips64.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/objects.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M src/ppc/code-stubs-ppc.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/s390/code-stubs-s390.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/x87/code-stubs-x87.cc View 1 chunk +2 lines, -1 line 0 comments Download
M tools/gyp/v8.gyp View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (9 generated)
Toon Verwaest
ptal
4 years, 9 months ago (2016-03-09 17:56:37 UTC) #2
Jakob Kummerow
lgtm https://codereview.chromium.org/1776353002/diff/1/src/arm/code-stubs-arm.cc File src/arm/code-stubs-arm.cc (right): https://codereview.chromium.org/1776353002/diff/1/src/arm/code-stubs-arm.cc#newcode20 src/arm/code-stubs-arm.cc:20: #include "src/arm/code-stubs-arm.h" nit: arguably this is the include ...
4 years, 9 months ago (2016-03-10 10:27:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1776353002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1776353002/1
4 years, 9 months ago (2016-03-10 10:28:40 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/12158)
4 years, 9 months ago (2016-03-10 10:43:45 UTC) #7
Michael Achenbach
The test262 failure is being cleaned up in a moment...
4 years, 9 months ago (2016-03-10 10:50:10 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1776353002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1776353002/1
4 years, 9 months ago (2016-03-10 10:55:13 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/12165)
4 years, 9 months ago (2016-03-10 11:02:06 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1776353002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1776353002/1
4 years, 9 months ago (2016-03-10 12:14:27 UTC) #15
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-10 12:14:52 UTC) #17
commit-bot: I haz the power
4 years, 9 months ago (2016-03-10 12:16:11 UTC) #19
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5c73b25ff58e32bcd69153de15a786210769426c
Cr-Commit-Position: refs/heads/master@{#34664}

Powered by Google App Engine
This is Rietveld 408576698