Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Unified Diff: src/api-arguments.cc

Issue 1776353002: Split off api-arguments.[h|cc] from arguments.[h|cc] (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/api-arguments.cc
diff --git a/src/arguments.cc b/src/api-arguments.cc
similarity index 86%
copy from src/arguments.cc
copy to src/api-arguments.cc
index 077991bbee9390b1ba4b0e389c4ab0e273f594c3..fabfd49914413c139ee188dc2fb83d9d694523b7 100644
--- a/src/arguments.cc
+++ b/src/api-arguments.cc
@@ -1,8 +1,8 @@
-// Copyright 2013 the V8 project authors. All rights reserved.
+// Copyright 2016 the V8 project authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#include "src/arguments.h"
+#include "src/api-arguments.h"
#include "src/api.h"
#include "src/vm-state-inl.h"
@@ -10,7 +10,6 @@
namespace v8 {
namespace internal {
-
template <typename T>
template <typename V>
v8::Local<V> CustomArguments<T>::GetReturnValue(Isolate* isolate) {
@@ -21,20 +20,16 @@ v8::Local<V> CustomArguments<T>::GetReturnValue(Isolate* isolate) {
return Utils::Convert<Object, V>(Handle<Object>(handle));
}
-
v8::Local<v8::Value> FunctionCallbackArguments::Call(FunctionCallback f) {
Isolate* isolate = this->isolate();
VMState<EXTERNAL> state(isolate);
ExternalCallbackScope call_scope(isolate, FUNCTION_ADDR(f));
- FunctionCallbackInfo<v8::Value> info(begin(),
- argv_,
- argc_,
+ FunctionCallbackInfo<v8::Value> info(begin(), argv_, argc_,
is_construct_call_);
f(info);
return GetReturnValue<v8::Value>(isolate);
}
-
#define WRITE_CALL_0(Function, ReturnValue) \
v8::Local<ReturnValue> PropertyCallbackArguments::Call(Function f) { \
Isolate* isolate = this->isolate(); \
@@ -45,7 +40,6 @@ v8::Local<v8::Value> FunctionCallbackArguments::Call(FunctionCallback f) {
return GetReturnValue<ReturnValue>(isolate); \
}
-
#define WRITE_CALL_1(Function, ReturnValue, Arg1) \
v8::Local<ReturnValue> PropertyCallbackArguments::Call(Function f, \
Arg1 arg1) { \
@@ -57,7 +51,6 @@ v8::Local<v8::Value> FunctionCallbackArguments::Call(FunctionCallback f) {
return GetReturnValue<ReturnValue>(isolate); \
}
-
#define WRITE_CALL_2(Function, ReturnValue, Arg1, Arg2) \
v8::Local<ReturnValue> PropertyCallbackArguments::Call( \
Function f, Arg1 arg1, Arg2 arg2) { \
@@ -69,7 +62,6 @@ v8::Local<v8::Value> FunctionCallbackArguments::Call(FunctionCallback f) {
return GetReturnValue<ReturnValue>(isolate); \
}
-
#define WRITE_CALL_2_VOID(Function, ReturnValue, Arg1, Arg2) \
void PropertyCallbackArguments::Call(Function f, Arg1 arg1, Arg2 arg2) { \
Isolate* isolate = this->isolate(); \
@@ -79,7 +71,6 @@ v8::Local<v8::Value> FunctionCallbackArguments::Call(FunctionCallback f) {
f(arg1, arg2, info); \
}
-
FOR_EACH_CALLBACK_TABLE_MAPPING_0(WRITE_CALL_0)
FOR_EACH_CALLBACK_TABLE_MAPPING_1(WRITE_CALL_1)
FOR_EACH_CALLBACK_TABLE_MAPPING_2(WRITE_CALL_2)
@@ -90,14 +81,5 @@ FOR_EACH_CALLBACK_TABLE_MAPPING_2_VOID_RETURN(WRITE_CALL_2_VOID)
#undef WRITE_CALL_2
#undef WRITE_CALL_2_VOID
-
-double ClobberDoubleRegisters(double x1, double x2, double x3, double x4) {
- // TODO(ulan): This clobbers only subset of registers depending on compiler,
- // Rewrite this in assembly to really clobber all registers.
- // GCC for ia32 uses the FPU and does not touch XMM registers.
- return x1 * 1.01 + x2 * 2.02 + x3 * 3.03 + x4 * 4.04;
-}
-
-
} // namespace internal
} // namespace v8
« no previous file with comments | « src/api-arguments.h ('k') | src/arguments.h » ('j') | src/arm/code-stubs-arm.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698