Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(289)

Issue 177633011: fixed issue 342591: Uninit Error reported from write at IPC::Channel::ChannelImpl::ProcessOutgoingM… (Closed)

Created:
6 years, 10 months ago by zhaoqin
Modified:
6 years, 8 months ago
Reviewers:
dcheng, eseidel
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Fix uninitialized field in WindowFeatures Initialize x, y, width, and height in WindowFeatures constructor to prevent warnings about using uninitialized memory. R=dcheng@chromium.org BUG=342591 TEST=manual Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=171963

Patch Set 1 #

Patch Set 2 : update commit message, PTAL #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M Source/core/page/WindowFeatures.h View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
zhaoqin
6 years, 10 months ago (2014-02-25 19:11:27 UTC) #1
dcheng
The change looks OK to me. But please update the CL description, since it gets ...
6 years, 9 months ago (2014-03-18 03:21:26 UTC) #2
zhaoqin
commit 5ffe441020b9748643de6530ac25a53c7579ad19 Author: zhaoqin@chromium.org <zhaoqin@chromium.org> Date: Tue Feb 25 13:46:50 2014 -0500 fix uninitialized field ...
6 years, 9 months ago (2014-03-18 15:20:14 UTC) #3
dcheng
lgtm
6 years, 8 months ago (2014-04-18 17:52:19 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zhaoqin@google.com/177633011/20001
6 years, 8 months ago (2014-04-18 17:52:40 UTC) #5
commit-bot: I haz the power
6 years, 8 months ago (2014-04-18 18:59:59 UTC) #6
Message was sent while issue was closed.
Change committed as 171963

Powered by Google App Engine
This is Rietveld 408576698